Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GumGum: removes deprecated banner sizes default #5372

Merged
merged 11 commits into from
Jun 16, 2020
Merged

GumGum: removes deprecated banner sizes default #5372

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
2054d72
uses encodeURIComponent inline
susyt Apr 14, 2020
0b031b8
Merge branch 'master' of https://github.com/prebid/Prebid.js
susyt Apr 15, 2020
791c9c6
adds test for jcsi param
susyt Apr 16, 2020
cc62a49
Merge branch 'master' of https://github.com/prebid/Prebid.js
susyt Apr 23, 2020
b21f2b7
Merge branch 'master' of https://github.com/prebid/Prebid.js
susyt May 8, 2020
a45aa24
adds request delay depending on previous response
susyt May 8, 2020
d85aa54
Merge branch 'master' of https://github.com/prebid/Prebid.js
susyt May 27, 2020
7b8c56f
adds inVideo param
susyt May 27, 2020
49cd13d
Merge branch 'master' of https://github.com/prebid/Prebid.js
susyt Jun 3, 2020
afd17fe
Merge branch 'master' of https://github.com/prebid/Prebid.js
susyt Jun 12, 2020
ff80c0c
removes deprecated bidRequest.sizes
susyt Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/gumgumBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ function buildRequests (validBidRequests, bidderRequest) {
tId: transactionId,
pi: data.pi,
selector: params.selector,
sizes: bannerSizes || bidRequest.sizes,
sizes: bannerSizes,
url: BID_ENDPOINT,
method: 'GET',
data: Object.assign(data, _getBrowserParams(topWindowUrl), _getDigiTrustQueryParams(userId), _getTradeDeskIDParam(userId))
Expand Down