Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test case for missing adomain in ix adapter #5422

Merged
merged 4 commits into from
Jul 20, 2020
Merged

add test case for missing adomain in ix adapter #5422

merged 4 commits into from
Jul 20, 2020

Conversation

patmmccann
Copy link
Collaborator

at request of @ix-prebid-support on #5404, this adds a test case for when adomain is missing from the bid response

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 18, 2020
@jsnellbaker jsnellbaker removed the stale label Jul 20, 2020
@jsnellbaker jsnellbaker merged commit 13a347a into prebid:prebid-4.0 Jul 20, 2020
jsnellbaker added a commit that referenced this pull request Jul 23, 2020
* remove these adapters from 4.0 (#5369)

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>

* add meta key to interpreted bid response (#5358)

* add meta key to interpreted bid response

* add more unit tests

Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>

* add adomain to bid.meta in spotx adapter (#5401)

* add adomain to bid.meta in spotx adapter


this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for SpotX

* Update spotxBidAdapter.js

* Update spotxBidAdapter.js

* unit test for adomain on spotx adapter

* Update spotxBidAdapter_spec.js

* Update spotxBidAdapter_spec.js

* adds advertiserDomains meta to the pubmatic adapter (#5402)

* adds advertiserDomains meta

* Update pubmaticBidAdapter.js

* unit test for meta.advertiserDomains to pubmatic

* Update pubmaticBidAdapter_spec.js

* TCF Purpose 1 and Purpose 2 enforcement for Prebid v4.0 (#5336)

* TCF v2.0 enforcement

* test/spec/modules/gdprEnforcement_spec.js

* add check for gdpr version

* add logInfo message

* remove comment and store value of PURPOSES in an object

* add gvlid check

* add unit tests for validateRules function

* remove purposeId parameter from validateRules function

* add extra tests

* make failing unit test case pass

* deprecate allowAuctionWithouConsent with tcf 2 workflow

* add extra checks for defaults

* remove tcf 2 test page

* add strict gvlid check

* add comments and shorten log messages

* shorted log messages

* add unit tests for setEnforcementConfig

* add gvlid for alias and gvlMapping support

* remove gvlid check

* add support to add gvlid for aliases

Co-authored-by: Jaimin Panchal <email@example.com>

* add advertiserDomains meta field to ix adapter (#5404)

* add advertiserDomains meta field to ix adapter

* Update ixBidAdapter.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* add adomain to bid.meta in telaria adapter (#5400)

* add adomain to bid.meta in telaria adapter

this puts the adomain key in the right spot, related to #5358 and partially solves #3115 for Telaria

* Remove digitrust from prebid server js adapter (#5438)

* Update prebidServerBidAdapter_spec.js

* Update index.js

* Interactive advertising bureau digitrust exit (#5429)

* Removing DigiTrust ID system core.

* Removing test spec for digitrust id.

* Removing DigiTrust references from eids test spec.

Co-authored-by: Chris Cole <goosemanjack@gmail.com>

* Delete serverbidBidAdapter.md (#5477)

deprecated in favor of consumable adapter

* Set cookie domain in pubcid / userid on main domain, not subdomain (#5500)

* update formatting

* update formatting

* requested changes implemented

* add unit test

* add test case for missing adomain in ix adapter (#5422)

* add test case for missing adomain in ix adapter

at request of @ix-prebid-support on #5404

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* Update ixBidAdapter_spec.js

* drop support for userId configs with the `usersync` config object (#5427)

* drop support for userId configs with the `usersync` config object, per deprecation notice

* changes on drop support (#1)

* Update userIdTargeting.md

* Update userId.md

* Update userId_spec.js

* Update britepoolIdSystem.md

* Update sharedIdSystem.md

Co-authored-by: Patrick McCann <patmmccann@gmail.com>

Co-authored-by: sumit sharma <sharmasumit116@gmail.com>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.SYNAPPNXS.local>
Co-authored-by: sumit sharma <sumit.sharma1@SYNPUNLT9114TFL.appnexus.com>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: Jaimin Panchal <email@example.com>
Co-authored-by: Neelanjan Sen <neelanjan.sen@gmail.com>
Co-authored-by: Chris Cole <goosemanjack@gmail.com>
Co-authored-by: Isaac A. Dettman <idettman@rubiconproject.com>
Co-authored-by: Scott <smenzer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants