Add meta.advertiserDomains to pbs adapter #5437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-chowla
added
the
needs 2nd review
robertrmartinez
approved these changes
Jul 6, 2020
|
Yeah it's supposed to be an array
…On Mon, Jul 6, 2020, 2:54 PM Robert Ray Martinez III < ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good, just one question
------------------------------
In modules/prebidServerBidAdapter/index.js
<#5437 (comment)>:
> @@ -830,6 +830,8 @@ const OPEN_RTB_PROTOCOL = {
bidObject.creativeId = bid.crid;
if (bid.burl) { bidObject.burl = bid.burl; }
bidObject.currency = (response.cur) ? response.cur : DEFAULT_S2S_CURRENCY;
+ bidObject.meta = bidObject.meta || {};
+ if (bid.adomain) { bidObject.meta.advertiserDomains = bid.adomain; }
Is advertiserDomains supposed to be an array?
I see the test has it
expect(response.meta.advertiserDomains[0]).to.equal('appnexus.com'); but
just making sure that PBS is responding with an array on the bid.adomain
key.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5437 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM25Z2EA3SYOATIITMIYZ3R2IMWDANCNFSM4OLOT6RA>
.
|
|
@robertrmartinez is this good to merge? |
|
Yep 👍 |
|
@robertrmartinez sorry i don't have write permission to merge, the last reviewer has merged other things i submitted. Is that not what normally happens? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This copies adomain into bid.meta.advertiserDomains for prebid server respones