Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bright Mountain Media Bid Adapter #5593

Merged
merged 3 commits into from
Aug 18, 2020

Conversation

BrightMountainMediaInc
Copy link

@BrightMountainMediaInc BrightMountainMediaInc commented Aug 10, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  "bidder": "brightmountainmedia",
  "params": {
    "placement_id": "5f21784949be81002079d08c",
    "traffic": "banner"
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When trying the adapter with hello_world.html test page, I see this in prebid logs:

WARNING: Bidder brightmountainmedia made bid for unknown request ID: . Ignoring.

If the bidder adds a requestId to the response, even when the bid is empty, the warning would go away.

Also: did you prepare a PR for the documentation website?

modules/brightMountainMediaBidAdapter.md Outdated Show resolved Hide resolved
@bretg
Copy link
Collaborator

bretg commented Aug 13, 2020

docs PR prebid/prebid.github.io#2220

@BrightMountainMediaInc
Copy link
Author

When trying the adapter with hello_world.html test page, I see this in prebid logs:

WARNING: Bidder brightmountainmedia made bid for unknown request ID: . Ignoring.

If the bidder adds a requestId to the response, even when the bid is empty, the warning would go away.

Also: did you prepare a PR for the documentation website?

Thanks @bretg for linking the docs PR.

WARNING: Bidder brightmountainmedia made bid for unknown request ID: . Ignoring.

requestId is now being sent on every response so this warning won't appear anymore.

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele musikele merged commit 8646ba7 into prebid:master Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants