Adhese: set gvlid && filter out empty params #5602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question: @mefjush, what suppose to happen if the parameter is a string with only space ' '? Current logic won't filter it out, not sure if that is expected. |
|
That's certainly a valid question as indeed just a space is not a valid input. After a consideration we'd prefer to keep the "filtering" as it is. We'd rather catch all less common incorrect values in our backend so we are aware of them and can act if necessary. |
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
BrightMountainMediaInc
added a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
… Adhese request size (prebid#5602)" This reverts commit cef44e9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Configure the gvlid for Adhese adapter
Reduce the outgoing request size in case the user provided empty parameters