Price Floors: Add bid object into cpmAdjustment function
#5609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertrmartinez
commented
Aug 20, 2020
| const adjustmentFunction = utils.deepAccess(getGlobal(), `bidderSettings.${bidderName}.bidCpmAdjustment`); | ||
| if (adjustmentFunction) { | ||
| return parseFloat(adjustmentFunction(inputCpm)); | ||
| return parseFloat(adjustmentFunction(inputCpm, {...bid, cpm: inputCpm})); |
There was a problem hiding this comment.
If this is called at bidRequest time, we do not really have a bidResponse object, so we''ll make a pseduo one with the cpm. Where cpm is actually the resulting floor from the adapters getFloor call.
robertrmartinez
requested review from
Fawke
and removed request for
jaiminpanchal27
Fawke
approved these changes
Aug 24, 2020
idettman
approved these changes
Aug 26, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
BrightMountainMediaInc
added a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
…)" This reverts commit 8e736fc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The priceFloors module has to run the
bidCpmAdjustmentfunction if a bidder has it.Turns out, that not only is the cpm value needing to be passed into the adjustment function, but some publishers use the bidResponse object to grab the CPM (even though they are the same)
It is possible publishers to more intricate logic with this, so we will pass along the bidResponse object so it works in all scenarios!