Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds advertiserDomains to kargo adapter #5625

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Adds advertiserDomains to kargo adapter #5625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0a8617
Update kargoBidAdapter.js
patmmccann Aug 18, 2020
d96adcf
Update kargoBidAdapter_spec.js
patmmccann Aug 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/kargoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,8 @@ export const spec = {
let meta;
if (adUnit.metadata && adUnit.metadata.landingPageDomain) {
meta = {
clickUrl: adUnit.metadata.landingPageDomain
clickUrl: adUnit.metadata.landingPageDomain,
advertiserDomains: [adUnit.metadata.landingPageDomain]
};
}
bidResponses.push({
Expand Down
3 changes: 2 additions & 1 deletion test/spec/modules/kargoBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,7 +505,8 @@ describe('kargo adapter tests', function () {
netRevenue: true,
currency: 'USD',
meta: {
clickUrl: 'https://foobar.com'
clickUrl: 'https://foobar.com',
advertiserDomains: ['https://foobar.com']
}
}, {
requestId: '3',
Expand Down