Chrome 85.0.4183 fix for SameSite=None cookie rejection policy

[bansawbanchee]

Tests for this Analytics Adapter fail locally without this change when a user is using Chrome 85 or newer. Chrome 85 added rejection of insecure SameSite=None cookies. secure probably could have been added to fix this issue but SameSite=Lax works as well for the test case.

https://developers.google.com/web/updates/2020/07/chrome-85-deps-rems
https://en.wikipedia.org/wiki/Google_Chrome_version_history

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

[smenzer]

Shouldn't you be using storageManager rather than directly writing cookies via document.cookie?

[bansawbanchee]

This is not our adapter.

The tests for this adapter fail locally when I am trying to run gulp serve to test our userID submodule because my installed version of Chrome (85) on Mac is newer then the version Prebid BrowserStack tests against (Chrome 80).

Chrome 85 and newer includes the rejection for SameSite=None without secure flag so anybody who attempts to run tests locally on Chrome 85 or newer will receive these failed tests for this adapter.

I am only including this change to ensure the tests pass.

Here is the direct link to the update Chrome added that will make these tests fail if you have a newer version of Chrome installed locally. https://developers.google.com/web/updates/2020/07/chrome-85-deps-rems#reject_insecure_samesitenone_cookies

Maybe we should also update https://github.com/prebid/Prebid.js/blob/master/browsers.json to include newer versions of Chrome? Or change it from 80 to 85?

Here is the pull request that added that document.cookie in the spec: https://github.com/prebid/Prebid.js/pull/4292/files#diff-6ac962c2306f557acbe6661536d02c30R10

[patmmccann]

LGTM

[smenzer]

this adapter probably needs to update to use storageManager, but as this is a quick fix to get tests working again, I'll merge it.