Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support IE in aol spec #5894

Merged
merged 2 commits into from
Oct 28, 2020
Merged

support IE in aol spec #5894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2d0787
support IE in aol spec
robertrmartinez Oct 23, 2020
82a544d
array includes not supported IE11
robertrmartinez Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/aolBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ function resolveEndpointCode(bid) {

function getSupportedEids(bid) {
return bid.userIdAsEids.filter(eid => {
return SUPPORTED_USER_ID_SOURCES.includes(eid.source)
return SUPPORTED_USER_ID_SOURCES.indexOf(eid.source) !== -1
});
}

Expand Down
6 changes: 3 additions & 3 deletions test/spec/modules/aolBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,17 +490,17 @@ describe('AolAdapter', function () {
'&param1=val1&param2=val2&param3=val3&param4=val4');
});

for (const [source, idValue] of Object.entries(SUPPORTED_USER_ID_SOURCES)) {
Object.keys(SUPPORTED_USER_ID_SOURCES).forEach(source => {
it(`should set the user ID query param for ${source}`, function () {
let bidRequest = createCustomBidRequest({
params: getNexageGetBidParams()
});
bidRequest.bids[0].userId = {};
bidRequest.bids[0].userIdAsEids = createEidsArray(USER_ID_DATA);
let [request] = spec.buildRequests(bidRequest.bids);
expect(request.url).to.contain(`&eid${source}=${encodeURIComponent(idValue)}`);
expect(request.url).to.contain(`&eid${source}=${encodeURIComponent(SUPPORTED_USER_ID_SOURCES[source])}`);
});
}
});

it('should return request object for One Mobile POST endpoint when POST configuration is present', function () {
let bidConfig = getNexagePostBidParams();
Expand Down