sspBC adapter: update to v4.6 (notifications, user sync) #5941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…set test mode in adexchange, read site SN from bid response
Update sspbc-adapter branch
Update sspbc-adapter branch
Update sspbc-adapter branch
Update sspbc-adapter branch
Update adapter to v4.6 - add notification endpoint - send bidWon and onTimeout notifications - send CMP version to user sync endpoint
wojciech-bialy-wpm
changed the title
|
please add unit tests @wojciech-bialy-wpm |
|
In order to approve your PR, could you please
You should add in your conditions: |
Update sspbc-adapter branch
|
Sorry for the delay. Tests updated:
In the last two cases, while I can't get sinon to work with Prebid.js ajax module (similar case as in #3842) methods now check whether notification payload is correctly constructed. |
|
@wojciech-bialy-wpm, where is your updated test file please? I can't see it in your the files changed of this PR. |
Update tests for sspBC adapter: - add onBidWon test - add onTimeout test - alter getUserSyncs test
|
@osazos Oh, I see the last commit (with changes to test/spec/modules/sspBCAdapter_spec.js) did not go through. Updating now. |
stsepelin
pushed a commit
to cointraffic/Prebid.js
that referenced
this pull request
May 28, 2021
Update adapter to v4.6 - add notification endpoint - send bidWon and onTimeout notifications - send CMP version to user sync endpoint Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Update sspBC adapter to v4.6: