Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update quantcastBidAdapter to make user sync flag non-constant #5949

Merged
merged 1 commit into from
Nov 16, 2020

Conversation

mckurt
Copy link
Contributor

@mckurt mckurt commented Nov 9, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

This PR updates quantcastBidAdapter to move hasUserSynced flag out of the spec object and make it non-constant. Otherwise, the adapter throws an error with the following message, when the flag's value is changed in strict mode: "Uncaught TypeError: "hasUserSynced" is read-only"

@robertrmartinez robertrmartinez self-assigned this Nov 13, 2020
@mckurt
Copy link
Contributor Author

mckurt commented Nov 15, 2020

@robertrmartinez Thanks for the review. When can we merge this PR?

@robertrmartinez robertrmartinez merged commit a4a194c into prebid:master Nov 16, 2020
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants