Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adkernelBidAdapter.js #5957

Merged
merged 2 commits into from
Nov 30, 2020
Merged

Update adkernelBidAdapter.js #5957

merged 2 commits into from
Nov 30, 2020

Conversation

Avimobi
Copy link
Contributor

@Avimobi Avimobi commented Nov 12, 2020

description: Prebid adbite Bidder Adaptor
Host: cpm.adbite.com

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

description: Prebid adbite Bidder Adaptor
Host: cpm.adbite.com
@robertrmartinez robertrmartinez self-assigned this Nov 13, 2020
@robertrmartinez robertrmartinez self-requested a review November 13, 2020 17:46
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine but add / update your tests for aliases.

They are failing

Copy link
Contributor Author

@Avimobi Avimobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have change the array and count which you suggested. plz check and let us know if you need anything else.

@robertrmartinez
Copy link
Collaborator

@Avimobi

Did you forget to check in and push to this branch?

Still to associated change to the _spec file.

I do not see a commit since my comment.

@robertrmartinez robertrmartinez mentioned this pull request Nov 24, 2020
10 tasks
@robertrmartinez
Copy link
Collaborator

@Avimobi I see you added two new PR's

I have closed those and ask that you simply update this PR with the changes to the spec file please.

@Avimobi
Copy link
Contributor Author

Avimobi commented Nov 26, 2020

Hello robert
I am extremely sorry for delay. I have made changes to _spec file and committed to same branch. Plz check and let me know in case you need any thing else.

@robertrmartinez
Copy link
Collaborator

no worries. Thanks for making the update

@robertrmartinez robertrmartinez self-requested a review November 30, 2020 19:21
@robertrmartinez robertrmartinez merged commit 4b3faf4 into prebid:master Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants