Rubicon Analytics Adapter: Fix source format issue #5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
The adapter saves all bidder names as lowercase.
So when it compared the bidders array in s2sConfig with the saved bidder code, it would fail if the server bidder code was not lowercase. (pgRubicon compared with pgrubicon).
This addresses this by using .some and doing full lowercase compare.
But also adds in better logic, because since a long time ago the
srcparam is on every single bidRequest, so instead of all this extra logic to figure it out (which we will leave in for now) we can just directly set source on initial bid request event.