Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneVideo Adapter - Custom Key Value Pair targeting support (SAPR-15478) #6053

Merged
merged 9 commits into from
Dec 2, 2020
Merged

oneVideo Adapter - Custom Key Value Pair targeting support (SAPR-15478) #6053

merged 9 commits into from
Dec 2, 2020

Conversation

adam-browning
Copy link
Contributor

Type of change

  • [ x] Feature

Description of change

oneVideo adapter now supports Custom key value pairs for targeting in the Video SSP ad-server.
You can pass an Object with key value pairs under `bid.params.video.custom = {}``.
Supported values are String and Number only

  • test parameters for validating bids
bids: [{
                bidder: 'oneVideo',
                params: {
                    video: {
                        playerWidth: 640,
                        playerHeight: 480,
                        mimes: ['video/mp4', 'application/javascript'],
                        protocols: [2, 5],
                        api: [1, 2],
                        custom :{
                            key1: "value1",
                            key2: "value2",
                            key3: "value3",
                            key4: 4444444,
                        },
                        e2etest: true
                    },
                    pubId: 'whatever'
                }
            }]

Other information

@kprasadpvv would appreciate your review whenever convenient :)
Thanks in advance

@kprasadpvv
Copy link

kprasadpvv commented Dec 1, 2020

@adam-browning can you also update sample object in oneVideoBidAdapter.md please
https://github.com/prebid/Prebid.js/blob/d74ad80d4e53529148fa3b7b1da2f6affd88bd60/modules/oneVideoBidAdapter.md

Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FilipStamenkovic FilipStamenkovic merged commit 6d29360 into prebid:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants