Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test unit to match new alias bidder count (Adkernel) #6054

Closed
wants to merge 1 commit into from
Closed

Update test unit to match new alias bidder count (Adkernel) #6054

wants to merge 1 commit into from

Conversation

iskmerof
Copy link
Contributor

Type of change

  • Other

Description of change

Update test unit for alias count

@aleksatr
Copy link
Contributor

aleksatr commented Dec 2, 2020

Hi @iskmerof , the test in question is failing, check circleci output, the number of aliases in spec.aliases seems to be 8, so I'm not sure where does this 9 come from?

@aleksatr
Copy link
Contributor

aleksatr commented Dec 2, 2020

@iskmerof , ok I see, it's coming from this PR https://github.com/prebid/Prebid.js/pull/6055, can you just merge these two into one PR? or just push this commit (git cherry-pick e6fec67eadcc0c73394cf86dd8520ff5f60ed729) to iskmerof:patch-1 and then you can safely close this PR?

@iskmerof
Copy link
Contributor Author

iskmerof commented Dec 2, 2020

@aleksatr Thank you. No problem, will either close or merge them. There's some difficulties with GH UI in doing multiple commits in one PR.

@aleksatr
Copy link
Contributor

aleksatr commented Dec 4, 2020

@iskmerof , I pushed this commit to #6055 for you, I'll close this one now.

@iskmerof
Copy link
Contributor Author

iskmerof commented Dec 4, 2020

@aleksatr Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants