Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appnexus: Remove tpuids array from request payload. #6074

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Appnexus: Remove tpuids array from request payload. #6074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions modules/appnexusBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,16 +231,10 @@ export const spec = {
const criteoId = utils.deepAccess(bidRequests[0], `userId.criteoId`);
let eids = [];
if (criteoId) {
let tpuids = [];
tpuids.push({
'provider': 'criteo',
'user_id': criteoId
});
eids.push({
source: 'criteo.com',
id: criteoId
});
payload.tpuids = tpuids;
}

const tdid = utils.deepAccess(bidRequests[0], `userId.tdid`);
Expand Down
7 changes: 1 addition & 6 deletions test/spec/modules/appnexusBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,7 +808,7 @@ describe('AppNexusAdapter', function () {
expect(request.options).to.deep.equal({withCredentials: false});
});

it('should populate eids and tpuids when ttd id and criteo is available', function () {
it('should populate eids when ttd id and criteo is available', function () {
const bidRequest = Object.assign({}, bidRequests[0], {
userId: {
tdid: 'sample-userid',
Expand All @@ -828,11 +828,6 @@ describe('AppNexusAdapter', function () {
source: 'criteo.com',
id: 'sample-criteo-userid',
});

expect(payload.tpuids).to.deep.include({
provider: 'criteo',
user_id: 'sample-criteo-userid',
});
});

it('should populate iab_support object at the root level if omid support is detected', function () {
Expand Down