Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GMOSSP Bid Adapter : add refererInfo from bidderRequest #6319

Merged
merged 2 commits into from
Feb 25, 2021
Merged

GMOSSP Bid Adapter : add refererInfo from bidderRequest #6319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4380e74
Add referer, url supported canonicalUrl to GMOSSP adapter
KazuakiM Feb 5, 2021
75beab5
CircleCI Error fix, prebid version
KazuakiM Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions modules/gmosspBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ export const spec = {
buildRequests: function (validBidRequests, bidderRequest) {
const bidRequests = [];

const url = bidderRequest.refererInfo.referer;
const urlInfo = getUrlInfo(bidderRequest.refererInfo);
const cur = getCurrencyType();
const dnt = utils.getDNT() ? '1' : '0';

Expand All @@ -46,7 +46,8 @@ export const spec = {
queryString = utils.tryAppendQueryString(queryString, 'bid', bid);
queryString = utils.tryAppendQueryString(queryString, 'ver', ver);
queryString = utils.tryAppendQueryString(queryString, 'sid', sid);
queryString = utils.tryAppendQueryString(queryString, 'url', url);
queryString = utils.tryAppendQueryString(queryString, 'url', urlInfo.url);
queryString = utils.tryAppendQueryString(queryString, 'ref', urlInfo.ref);
queryString = utils.tryAppendQueryString(queryString, 'cur', cur);
queryString = utils.tryAppendQueryString(queryString, 'dnt', dnt);

Expand Down Expand Up @@ -131,4 +132,31 @@ function getCurrencyType() {
return 'JPY';
}

function getUrlInfo(refererInfo) {
return {
url: getUrl(refererInfo),
ref: getReferrer(),
};
}

function getUrl(refererInfo) {
if (refererInfo && refererInfo.referer) {
return refererInfo.referer;
}

try {
return window.top.location.href;
} catch (e) {
return window.location.href;
}
}

function getReferrer() {
try {
return window.top.document.referrer;
} catch (e) {
return document.referrer;
}
}

registerBidder(spec);
24 changes: 18 additions & 6 deletions test/spec/modules/gmosspBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,18 +54,30 @@ describe('GmosspAdapter', function () {
}
];

const bidderRequest = {
refererInfo: {
referer: 'https://hoge.com'
}
};

it('sends bid request to ENDPOINT via GET', function () {
const bidderRequest = {
refererInfo: {
referer: 'https://hoge.com'
}
};

const requests = spec.buildRequests(bidRequests, bidderRequest);
expect(requests[0].url).to.equal(ENDPOINT);
expect(requests[0].method).to.equal('GET');
expect(requests[0].data).to.equal('tid=791e9d84-af92-4903-94da-24c7426d9d0c&bid=2b84475b5b636e&ver=$prebid.version$&sid=123456&url=https%3A%2F%2Fhoge.com&cur=JPY&dnt=0&');
});

it('should use fallback if refererInfo.referer in bid request is empty', function () {
const bidderRequest = {
refererInfo: {
referer: ''
}
};

const requests = spec.buildRequests(bidRequests, bidderRequest);
const result = 'tid=791e9d84-af92-4903-94da-24c7426d9d0c&bid=2b84475b5b636e&ver=$prebid.version$&sid=123456&url=' + encodeURIComponent(window.top.location.href) + '&cur=JPY&dnt=0&';
expect(requests[0].data).to.equal(result);
});
});

describe('interpretResponse', function () {
Expand Down