Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneVideo Bid Adapter: remove adapter adId because of conflict with pbjs core #6382

Merged
merged 31 commits into from
Mar 4, 2021
Merged

oneVideo Bid Adapter: remove adapter adId because of conflict with pbjs core #6382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
12ddf51
updated object,str,num validations using pbjs utils
Dec 9, 2020
1e01733
validation if statements for content object
Dec 9, 2020
9dc4acf
validation if statements for content object
Dec 9, 2020
46fa4b3
updated contetn object validations using utils
Dec 9, 2020
8a3f396
refractoring clean if statement
Dec 9, 2020
f3dd28c
fixing typos
Dec 9, 2020
8ec2a8e
Merge branch 'master' into SAPR-15477
Dec 9, 2020
fed03fe
added todos
Dec 9, 2020
5233cce
added category string & data object validations
Dec 10, 2020
3edfd61
fixed esling ENDPOINT issue
Dec 10, 2020
0713594
updated content obj unit tests
Dec 10, 2020
5560a17
fixed cat & data validation
Dec 10, 2020
35d4c9e
Merge branch 'master' into SAPR-15477
Dec 10, 2020
04797dd
fixed producer as object
Dec 10, 2020
4d19186
revert .includes() to .indexof() for IE
Dec 10, 2020
80e95ea
reduced content obj params accoriding to ad-server support
Dec 10, 2020
664e68d
fixed typeOf typo
Dec 10, 2020
1a5047f
fixed episode to Number
Dec 10, 2020
1fb8829
Merge branch 'master' into SAPR-15477
Dec 14, 2020
f90ef3a
gitignore
Dec 14, 2020
d2be3f0
restore gitignore
Dec 14, 2020
1135493
removed unsupported params from md file
Dec 14, 2020
e428293
reverted package & pagkage-lock
Dec 14, 2020
89b7985
fixed incorrect episdoe from str to num
Dec 14, 2020
631c2f6
Merge branch 'master' of https://github.com/prebid/Prebid.js
Dec 15, 2020
8c547ad
Merge remote-tracking branch 'upstream/master'
Dec 21, 2020
b0d44ff
Merge remote-tracking branch 'upstream/master'
Mar 3, 2021
35bdb72
removed bid.adid setting from L97
Mar 3, 2021
7920bfb
removed bid.adId setting
Mar 4, 2021
464034e
updated adId test
Mar 4, 2021
8ae80ff
updated version to 3.0.6
Mar 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions modules/oneVideoBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {registerBidder} from '../src/adapters/bidderFactory.js';
const BIDDER_CODE = 'oneVideo';
export const spec = {
code: 'oneVideo',
VERSION: '3.0.5',
VERSION: '3.0.6',
ENDPOINT: 'https://ads.adaptv.advertising.com/rtb/openrtb?ext_id=',
E2ETESTENDPOINT: 'https://ads-wc.v.ssp.yahoo.com/rtb/openrtb?ext_id=',
SYNC_ENDPOINT1: 'https://pixel.advertising.com/ups/57304/sync?gdpr=&gdpr_consent=&_origin=0&redir=true',
Expand Down Expand Up @@ -94,7 +94,6 @@ export const spec = {
requestId: bidRequest.bidId,
bidderCode: spec.code,
cpm: bid.price,
adId: bid.adid,
creativeId: bid.crid,
width: size.width,
height: size.height,
Expand Down
3 changes: 1 addition & 2 deletions test/spec/modules/oneVideoBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ describe('OneVideoBidAdapter', function () {
const placement = bidRequest.params.video.placement;
const rewarded = bidRequest.params.video.rewarded;
const inventoryid = bidRequest.params.video.inventoryid;
const VERSION = '3.0.5';
const VERSION = '3.0.6';
expect(data.imp[0].video.w).to.equal(width);
expect(data.imp[0].video.h).to.equal(height);
expect(data.imp[0].bidfloor).to.equal(bidRequest.params.bidfloor);
Expand Down Expand Up @@ -567,7 +567,6 @@ describe('OneVideoBidAdapter', function () {
requestId: bidRequest.bidId,
bidderCode: spec.code,
cpm: serverResponse.seatbid[0].bid[0].price,
adId: serverResponse.seatbid[0].bid[0].adid,
creativeId: serverResponse.seatbid[0].bid[0].crid,
vastXml: serverResponse.seatbid[0].bid[0].adm,
width: 640,
Expand Down