Optimize AOL adapter and heavily reduce the size #653
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,183 +1,140 @@ | ||
| const utils = require('../utils.js'); | ||
| const ajax = require('../ajax.js').ajax; | ||
| const bidfactory = require('../bidfactory.js'); | ||
| const bidmanager = require('../bidmanager.js'); | ||
|
|
||
| const AolAdapter = function AolAdapter() { | ||
|
|
||
| const pubapiTemplate = template`${'protocol'}://${'host'}/pubapi/3.0/${'network'}/${'placement'}/${'pageid'}/${'sizeid'}/ADTECH;v=2;cmd=bid;cors=yes;alias=${'alias'}${'bidfloor'};misc=${'misc'}`; | ||
| const BIDDER_CODE = 'aol'; | ||
| const SERVER_MAP = { | ||
| us: 'adserver-us.adtech.advertising.com', | ||
| eu: 'adserver-eu.adtech.advertising.com', | ||
| as: 'adserver-as.adtech.advertising.com' | ||
| }; | ||
|
|
||
| function template(strings, ...keys) { | ||
| return function(...values) { | ||
| let dict = values[values.length - 1] || {}; | ||
| let result = [strings[0]]; | ||
| keys.forEach(function(key, i) { | ||
| let value = Number.isInteger(key) ? values[key] : dict[key]; | ||
| result.push(value, strings[i + 1]); | ||
| }); | ||
| return result.join(''); | ||
| }; | ||
| } | ||
|
|
||
| function _buildPubapiUrl(bid) { | ||
| const params = bid.params; | ||
| const serverParam = params.server; | ||
| let regionParam = params.region || 'us'; | ||
| let server; | ||
|
|
||
| if (!SERVER_MAP.hasOwnProperty(regionParam)) { | ||
| console.warn(`Unknown region '${regionParam}' for AOL bidder.`); | ||
| regionParam = 'us'; // Default region. | ||
| } | ||
|
|
||
| if (serverParam) { | ||
| server = serverParam; | ||
| } else { | ||
| server = SERVER_MAP[regionParam]; | ||
| } | ||
|
|
||
| // Set region param, used by AOL analytics. | ||
| params.region = regionParam; | ||
|
|
||
| return pubapiTemplate({ | ||
| protocol: (document.location.protocol === 'https:') ? 'https' : 'http', | ||
| host: server, | ||
| network: params.network, | ||
| placement: parseInt(params.placement), | ||
| pageid: params.pageId || 0, | ||
| sizeid: params.sizeId || 0, | ||
| alias: params.alias || utils.getUniqueIdentifierStr(), | ||
| bidfloor: (typeof params.bidFloor !== 'undefined') ? | ||
| `;bidfloor=${params.bidFloor.toString()}` : '', | ||
| misc: new Date().getTime() // cache busting | ||
| }); | ||
| } | ||
|
|
||
| function _addErrorBidResponse(bid, response = {}) { | ||
| const bidResponse = bidfactory.createBid(2, bid); | ||
| bidResponse.bidderCode = BIDDER_CODE; | ||
| bidResponse.reason = response.nbr; | ||
| bidResponse.raw = response; | ||
| bidmanager.addBidResponse(bid.placementCode, bidResponse); | ||
| } | ||
|
|
||
| function _addBidResponse(bid, response) { | ||
| let bidData; | ||
|
|
||
| try { | ||
| bidData = response.seatbid[0].bid[0]; | ||
|
There was a problem hiding this comment. An empty bid or "no bid" response causes this to fail which throws an error, though a response with an empty There was a problem hiding this comment. When an error is thrown here, |
||
| } catch (e) { | ||
| _addErrorBidResponse(bid, response); | ||
| return; | ||
| } | ||
|
|
||
| let cpm; | ||
|
|
||
| if (bidData.ext && bidData.ext.encp) { | ||
| cpm = bidData.ext.encp; | ||
| } else { | ||
| cpm = bidData.price; | ||
|
|
||
| if (cpm === null || isNaN(cpm)) { | ||
| utils.logError('Invalid price in bid response', BIDDER_CODE, bid); | ||
| _addErrorBidResponse(bid, response); | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| let ad = bidData.adm; | ||
| if (bidData.ext && bidData.ext.pixels) { | ||
| ad += bidData.ext.pixels; | ||
| } | ||
|
|
||
| const bidResponse = bidfactory.createBid(1, bid); | ||
| bidResponse.bidderCode = BIDDER_CODE; | ||
| bidResponse.ad = ad; | ||
| bidResponse.cpm = cpm; | ||
| bidResponse.width = bidData.w; | ||
| bidResponse.height = bidData.h; | ||
| bidResponse.creativeId = bidData.crid; | ||
| bidResponse.pubapiId = response.id; | ||
| bidResponse.currencyCode = response.cur; | ||
| if (bidData.dealid) { | ||
| bidResponse.dealId = bidData.dealid; | ||
| } | ||
|
|
||
| bidmanager.addBidResponse(bid.placementCode, bidResponse); | ||
| } | ||
|
|
||
| function _callBids(params) { | ||
| utils._each(params.bids, bid => { | ||
| const pubapiUrl = _buildPubapiUrl(bid); | ||
|
|
||
| ajax(pubapiUrl, response => { | ||
| if (!response && response.length <= 0) { | ||
| utils.logError('Empty bid response', BIDDER_CODE, bid); | ||
| _addErrorBidResponse(bid, response); | ||
| return; | ||
|
There was a problem hiding this comment. For an empty bid response, you will still want to add a bid response, likely with There was a problem hiding this comment. Thanks for the suggestion. This is now fixed. |
||
| } | ||
|
|
||
| try { | ||
| response = JSON.parse(response); | ||
| } catch (e) { | ||
| utils.logError('Invalid JSON in bid response', BIDDER_CODE, bid); | ||
| _addErrorBidResponse(bid, response); | ||
| return; | ||
| } | ||
|
|
||
| _addBidResponse(bid, response); | ||
|
|
||
| }, null, { withCredentials: true }); | ||
| }); | ||
| } | ||
|
|
||
| return { | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.warndoesn't play nice in IE 9. Please useutils.logWarninstead for safety.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason for using
console.warn()directly is that this warning is meant to be shown when a publisher is configuring a site and uses incorrect region. I want to show the warning even if the debug mode is turned off, so the publisher can see what's wrong. And I expect publisher to be configuring it in a browser other than IE9 🤔. After the site is configured correctly, the warning should go away, so I believe it is safe to use thisconsole.warn(). If you feel otherwise, please let me know.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough I suppose. Thanks