Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-bidding adapter from 5.0 #6589

Closed
wants to merge 73 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
73 commits
Select commit Hold shift + click to select a range
b0c20ee
AdTrue Bid Adapter: getUserSyncs logic update (#6338)
haibau Mar 24, 2021
d2a0360
IX Bid Adapter: add priceFloors support and an integration example (#…
punkiller Mar 24, 2021
f3fe966
PBS adapter: remove condition on gdpr consentstring which isnt requir…
patmmccann Mar 24, 2021
9faeb68
if the stored value was an object, then it could end up with a space …
smenzer Mar 24, 2021
fa5c978
Kargo Bid Adapter: add gdpr support (#6447)
BernhardValenti Mar 24, 2021
1dc7c05
Bid Glass Adapter: Merge externally set targeting params (#6426)
dliebner Mar 24, 2021
f03e95a
Optimon Analytics Adapter: add new analytics adapter (#6333)
pixelgroup-israel Mar 24, 2021
95c5625
4.32.0 release
mkendall07 Mar 24, 2021
48cd16a
4.33.0-pre
mkendall07 Mar 24, 2021
94faa28
UID 2.0 Userid submodule (#6443)
SKOCHERI Mar 25, 2021
78b3a8b
H12media Bid Adapter: added new optional params, fixes, and various i…
h12media Mar 25, 2021
76c86e8
AdYouLike Bid Adapter: add video capabilities (#6398)
guiann Mar 25, 2021
b96f380
remove deprecated creative rendering example
ChrisHuie Mar 25, 2021
42182d6
Update Recommendation to install with 'npm ci' (#5697)
GLStephen Mar 25, 2021
c2f2046
Update eids.js
patmmccann Mar 25, 2021
c422dc9
Update eids_spec.js
patmmccann Mar 25, 2021
ec752ee
Update eids.js
patmmccann Mar 25, 2021
ea44e21
Update pubmaticBidAdapter_spec.js
patmmccann Mar 25, 2021
d44f298
Update eids.js
patmmccann Mar 25, 2021
10efcdd
Update eids_spec.js
patmmccann Mar 25, 2021
78fb35f
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
5c082a1
Update rubiconBidAdapter_spec.js
patmmccann Mar 25, 2021
09741b0
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
f42f6d8
Delete test/spec/adapters directory
patmmccann Mar 25, 2021
35de176
Update userId_spec.js
patmmccann Mar 25, 2021
5162ad8
Openx Bid Adapter: add floor support for Video (#6460)
kenan-gillet Mar 25, 2021
273e48b
Update to rubicon analytics adapter to pass along pbsBidId if present…
mmoschovas Mar 25, 2021
f3e0d4c
differentiate the IDs provided by ID5 when the user is opted out vs t…
smenzer Mar 25, 2021
ee468f7
AdagioBidAdapter: add capability to pass ext-data from localStorage i…
osazos Mar 26, 2021
9334c9b
Seedtag Bid Adapter: add connection type to bid request (#6457)
ybootin Mar 26, 2021
aa2463e
AdDefend Bid Adapter: new bid adapter (#6450)
addefend Mar 26, 2021
11b2dd2
GumGum Bid Adapter: adds meta field to bidresponse (#6478)
susyt Mar 27, 2021
7d76822
example integration file renamed to hello_world (#6475)
ChrisHuie Mar 29, 2021
d2e5956
Incorrect atypes on various eids (#6477)
patmmccann Mar 29, 2021
05869ed
added support for roundel alias (#6473)
lksharma Mar 29, 2021
971b515
Doceree Bid Adapter: new bid adapter (#6437)
sourbh-doceree Mar 29, 2021
078473b
Merge pull request #2 from prebid/master
patmmccann Mar 30, 2021
dc16781
OpenX Bidder Adapter: Add user ID sub-modules (#6490)
kenan-gillet Mar 30, 2021
c5cd4e2
Smaato: FPD Revision (#6459)
el-chuck Mar 30, 2021
7935df6
Conversant adapter: add adomain, remove digitrust (#6495)
patmmccann Mar 31, 2021
f316b20
Rads Bid Adapter: add GDPR support & user sync support (#6455)
onlsol Mar 31, 2021
1e73b57
Proxistore Bid Adapter: add cookieless url endpoint & use floor modul…
vincentproxistore Mar 31, 2021
5cc4405
AdYoulike Bid Adapter: Add an "Insertion" tracking for Native mediaty…
guiann Mar 31, 2021
508f72e
Dspx Bid Adapter : add user sync support (#6456)
onlsol Mar 31, 2021
a430753
Multibid Module: add new module to handle multiple bids from single b…
mmoschovas Mar 31, 2021
6655277
Adding uid2 to submodules.json (#6508)
SKOCHERI Mar 31, 2021
f986df0
NextRoll ID System: add new ID module (#6396)
abijr Apr 1, 2021
23943da
Qwarry Bid Adapter: add GDPR and consent string handling (#6489)
artemiokost Apr 1, 2021
108a3a6
Zemanta Bid Adapter: add support for new params & consent strings to …
Apr 1, 2021
7f9f0a2
Automatad Bid Adapter: Add meta.advertiserDomains to bid response (#6…
Apr 1, 2021
65c1079
Adhese Bid Adapter: add support for caching video content (#6501)
Apr 1, 2021
918149b
update apacdex unit test to disable debug mode (#6511)
jsnellbaker Apr 1, 2021
c78b49a
Telaria: not setting adid (#6507)
bretg Apr 1, 2021
b10fb27
Prebid 4.33.0 Release
jsnellbaker Apr 1, 2021
5ffe2c1
increment pre version
jsnellbaker Apr 1, 2021
84f70ff
rubicon: removing maxduration as a required bidder parameter (#6513)
bretg Apr 1, 2021
ebea754
Zemanta adapter: add advertiserDomains (#6517)
Apr 2, 2021
3c206da
Lemma Bid Adapter: accepting the floor to use the getFloor function (…
lm-abhijit Apr 2, 2021
91bcf42
Mediasquare Bid Adapter: fix getUserSyncs issue with empty bids + add…
matthieularere-msq Apr 2, 2021
1a4fec0
Update nextroll ID variable name to match published ID module (#6519)
abijr Apr 2, 2021
8b9f763
Merkle User ID Module: updates to user id submodule (#6503)
SKOCHERI Apr 3, 2021
a01dc2b
AdKernel Bid/Analytics Adapters: user privacy related changes (#6488)
ckbo3hrk Apr 5, 2021
7fce893
SynacorMedia: remove adId from the bid response (#6520)
rajcspsg Apr 5, 2021
e33442d
Rubicon: making doc data types consistent (#6526)
bretg Apr 5, 2021
3f5cff2
Synacormedia Bid Adapter: add meta.advertiserDomains (#6527)
rajcspsg Apr 5, 2021
dee10c3
Adloox Analytics Adapter: add new analytics adapter (#6308)
jimdigriz Apr 5, 2021
315f286
Seedtag adapter: Fixing bug preventing to receive the right params on…
lauramorillo Apr 6, 2021
e63cd6d
adot bid adapter: add publisher path from bidder config to endpoint u…
Giudici-a Apr 6, 2021
5e94a65
Admixer ID System: add userId submodule (#6238)
Galphimbl Apr 6, 2021
71fdd01
PBJS Core: call custom render func after loadscript if provided (#6422)
jeremiegirault Apr 6, 2021
b352c7d
Pubxai Analytics Adapter: bug fixes and code revamp (#6474)
pnhegde Apr 6, 2021
e7b5d01
Merge pull request #3 from prebid/master
patmmccann Apr 6, 2021
3501414
Delete iasBidAdapter.js
patmmccann Apr 14, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,11 @@ prebid.requestBids({

$ git clone https://github.com/prebid/Prebid.js.git
$ cd Prebid.js
$ npm install
$ npm ci

*Note:* You need to have `NodeJS` 12.16.1 or greater installed.

*Note:* In the 1.24.0 release of Prebid.js we have transitioned to using gulp 4.0 from using gulp 3.9.1. To comply with gulp's recommended setup for 4.0, you'll need to have `gulp-cli` installed globally prior to running the general `npm install`. This shouldn't impact any other projects you may work on that use an earlier version of gulp in its setup.
*Note:* In the 1.24.0 release of Prebid.js we have transitioned to using gulp 4.0 from using gulp 3.9.1. To comply with gulp's recommended setup for 4.0, you'll need to have `gulp-cli` installed globally prior to running the general `npm ci`. This shouldn't impact any other projects you may work on that use an earlier version of gulp in its setup.

If you have a previous version of `gulp` installed globally, you'll need to remove it before installing `gulp-cli`. You can check if this is installed by running `gulp -v` and seeing the version that's listed in the `CLI` field of the output. If you have the `gulp` package installed globally, it's likely the same version that you'll see in the `Local` field. If you already have `gulp-cli` installed, it should be a lower major version (it's at version `2.0.1` at the time of the transition).

Expand Down Expand Up @@ -265,7 +265,7 @@ directory you will have sourcemaps available in your browser's developer tools.

To run the example file, go to:

+ `http://localhost:9999/integrationExamples/gpt/pbjs_example_gpt.html`
+ `http://localhost:9999/integrationExamples/gpt/hello_world.html`

As you make code changes, the bundles will be rebuilt and the page reloaded automatically.

Expand Down
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ function test(done) {
} else {
var karmaConf = karmaConfMaker(false, argv.browserstack, argv.watch, argv.file);

var browserOverride = helpers.parseBrowserArgs(argv).map(helpers.toCapitalCase);
var browserOverride = helpers.parseBrowserArgs(argv);
if (browserOverride.length > 0) {
karmaConf.browsers = browserOverride;
}
Expand Down
112 changes: 112 additions & 0 deletions integrationExamples/gpt/adUnitFloors.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,112 @@
<!--
This page calls a single bidder for a single ad slot.
It is a specialized example for adding floors to bids using the priceFloors Module
It also makes a good test page for new adapter PR submissions. Simply set your server's Bid Params object in the
bids array inside the adUnits, and it will use your adapter to load an ad.
NOTE that many ad servers won't send back an ad if the URL is localhost... so you might need to
set an alias in your /etc/hosts file so that you can load this page from a different domain.
-->

<html>

<head>
<script async src="../../build/dist/prebid.js"></script>
<script async src="https://securepubads.g.doubleclick.net/tag/js/gpt.js"></script>
<script>
var FAILSAFE_TIMEOUT = 3300;
var PREBID_TIMEOUT = 1000;
var adUnits = [{
code: 'div-gpt-ad-51545-0',
sizes: [[300, 250], [600, 500]],
mediaTypes: {
banner: {
sizes: [[300, 250], [600, 500]]
}
},
// Replace this object to test a new Adapter!
bids: [{
bidder: 'ix',
params: {
siteId: '300',
size: [300, 250]
}
}]
}];
var pbjs = pbjs || {};
pbjs.que = pbjs.que || [];
</script>
<script>
var googletag = googletag || {};
googletag.cmd = googletag.cmd || [];
googletag.cmd.push(function () {
googletag.pubads().disableInitialLoad();
});

pbjs.que.push(function () {
pbjs.addAdUnits(adUnits);
pbjs.setConfig({
floors: {
enforcement: {
floorDeals: false, //default to false
bidAdjustment: true
},
data: { // default if endpoint doesn't return in time
currency: 'USD',
skipRate: 5,
modelVersion: 'BlackBerryZap',
schema: {
fields: ['gptSlot', 'mediaType', 'size']
},
values: {
'*|banner|600x500': 6.5,
'*|banner|300x250': 3.25,
'*|video': 3.5
}
}
}
});
pbjs.requestBids({
bidsBackHandler: sendAdserverRequest,
timeout: PREBID_TIMEOUT
});
});

function sendAdserverRequest() {
if (pbjs.adserverRequestSent) return;
pbjs.adserverRequestSent = true;
googletag.cmd.push(function () {
pbjs.que.push(function () {
pbjs.setTargetingForGPTAsync();
googletag.pubads().refresh();
});
});
}

setTimeout(function () {
sendAdserverRequest();
}, FAILSAFE_TIMEOUT);

</script>

<script>
googletag.cmd.push(function () {
googletag.defineSlot('/19968336/header-bid-tag-0', [[300, 250], [300, 600]], 'div-gpt-ad-51545-0').addService(googletag.pubads());

googletag.pubads().enableSingleRequest();
googletag.enableServices();
});
</script>
</head>

<body>
<h2>Prebid.js Test</h2>
<h5>Div-1</h5>
<div id='div-gpt-ad-51545-0'>
<script type='text/javascript'>
googletag.cmd.push(function () { googletag.display('div-gpt-ad-51545-0'); });
</script>
</div>
</body>

</html>

211 changes: 211 additions & 0 deletions integrationExamples/gpt/adloox.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,211 @@
<!DOCTYPE html>
<html>
<head>
<title>Prebid Display/Video Merged Auction with Adloox Integration</title>

<script async src="http://localhost:9999/build/dev/prebid.js"></script>
<!-- <script async src="https://storage.googleapis.com/adloox-ads-js-test/prebid.js"></script> -->
<script async src="//www.googletagservices.com/tag/js/gpt.js"></script>

<script>
// set to 10s (rather than 100ms) only to assist development as 'Local Overrides' stalls for >1s :-/
var AUCTION_DELAY = 10000; // recommended to be set to 100 in production
var PREBID_TIMEOUT = 1000;
var FAILSAFE_TIMEOUT = AUCTION_DELAY + (3 * PREBID_TIMEOUT);

var div_1_sizes = [ [728, 90] ];
var div_2_sizes = [ [300, 250] ];
var video_1_size = [ 640, 480 ];

var adUnits = [
{
code: 'div-1',
mediaTypes: {
banner: {
sizes: div_1_sizes
}
},
bids: [
{
bidder: 'rubicon',
params: {
accountId: 14062,
siteId: 70608,
zoneId: 498816
}
}
]
},
{
code: 'div-2',
mediaTypes: {
banner: {
sizes: div_2_sizes
}
},
bids: [
{
bidder: 'rubicon',
params: {
accountId: 14062,
siteId: 70608,
zoneId: 498816
}
}
]
}
];

var videoAdUnit = {
code: 'video-1',
mediaTypes: {
video: {
context: 'instream',
playerSize: [ 640, 480 ]
}
},
fpd: {
context: {
pbAdSlot: '/19968336/prebid_cache_video_adunit'
}
},
bids: [
{
bidder: 'spotx',
params: {
channel_id: 85394,
ad_unit: 'instream'
}
}
]
};

window.googletag = window.googletag || { cmd: [] };
googletag.cmd.push(function() {
googletag
.defineSlot('/19968336/header-bid-tag-0', div_1_sizes, 'div-1')
.addService(googletag.pubads());
googletag
.defineSlot('/19968336/header-bid-tag-1', div_2_sizes, 'div-2')
.addService(googletag.pubads());
googletag.pubads().disableInitialLoad();
googletag.pubads().enableSingleRequest();
googletag.enableServices();
});

var pbjs = pbjs || {};
pbjs.que = pbjs.que || [];

var tempTag = false;
var invokeVideoPlayer = function(url) {
tempTag = url;
};

function sendAdserverRequest(bids, timedOut, auctionId) {
if (pbjs.initAdserverSet) return;
pbjs.initAdserverSet = true;

googletag.cmd.push(function() {
pbjs.setTargetingForGPTAsync && pbjs.setTargetingForGPTAsync(adUnits);
googletag.pubads().refresh();
});

var videoBids = bids[videoAdUnit.code];
if (videoBids) {
var videoUrl = videoBids.bids[0].vastUrl;
// var videoUrl = pbjs.adServers.dfp.buildVideoUrl({
// adUnit: videoAdUnit,
// params: {
// iu: '/19968336/prebid_cache_video_adunit',
// cust_params: {
// section: 'blog',
// anotherKey: 'anotherValue'
// },
// output: 'vast'
// }
// });
invokeVideoPlayer(videoUrl);
}
}

// optionally wrap with googletag to have gpt-pre-auction
// automatically populate Prebid Ad Slot (pbAdSlot)
// https://docs.prebid.org/dev-docs/modules/gpt-pre-auction.html
// alternatively remove wrapping and set AdUnit.fpd.context.pbAdSlot
googletag.cmd.push(function() {
pbjs.que.push(function() {
pbjs.setConfig({
instreamTracking: {
enabled: true
},
rubicon: {
singleRequest: true
}
});
pbjs.enableAnalytics({
provider: 'adloox',
options: {
client: 'adlooxtest',
clientid: 127,
platformid: 0,
tagid: 0
}
});
pbjs.addAdUnits(adUnits);
pbjs.addAdUnits(videoAdUnit);
pbjs.requestBids({
bidsBackHandler: sendAdserverRequest,
timeout: PREBID_TIMEOUT
})
});
});

setTimeout(function() {
sendAdserverRequest();
}, FAILSAFE_TIMEOUT);
</script>
</head>
<body>
<h1>Prebid Display/Video Merged Auction with Adloox Integration</h1>

<h2>div-1</h2>
<div id="div-1">
<script>
googletag.cmd.push(function() {
googletag.display('div-1');
});
</script>
</div>

<h2>div-2</h2>
<div id="div-2">
<script>
googletag.cmd.push(function() {
googletag.display('div-2');
});
</script>
</div>

<h2>video-1</h2>
<div id="video-1"></div>
<script src="https://content.jwplatform.com/libraries/72xIKEe6.js"></script>
<script>
var playerInstance = jwplayer('video-1');
invokeVideoPlayer = function(url) {
playerInstance.setup({
"playlist": "https://content.jwplatform.com/feeds/ae4tmw2D.json",
"width": 640,
"height": 480,
"advertising": {
"client": "vast",
"tag": url
}
});
};
if (tempTag) {
invokeVideoPlayer(tempTag);
tempTag = false;
}
</script>
</body>
</html>
7 changes: 1 addition & 6 deletions integrationExamples/gpt/creative_rendering.html
Original file line number Diff line number Diff line change
@@ -1,9 +1,4 @@
<!-- #1 deprecated method - use preferred method below instead-->
<script>
try{ window.top.$$PREBID_GLOBAL$$.renderAd(document, '%%PATTERN:hb_adid%%'); } catch(e) {/*ignore*/}
</script>

<!-- #2 preferred method for showing ad - handles cases when $$PREBID_GLOBAL$$ is not in the top window -->
<!-- preferred method for showing ad - handles cases when $$PREBID_GLOBAL$$ is not in the top window -->
<script>
var w = window;
for (i = 0; i < 10; i++) {
Expand Down
Loading