appnexus bid adapter 5.0 - video params updates #6690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
added
feature
needs review
Prebid 5.0
|
Thanks! Could you also update https://github.com/prebid/Prebid.js/blob/appnexus5-video-params/modules/appnexusBidAdapter.md to demonstrate playback method isn't required to be in the params? |
|
Made an update on the md file. |
patmmccann
reviewed
May 5, 2021
patmmccann
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Related to #6512
This change updates the appnexus bidder to read more from the
mediaTypes.videoparams.It supports specific ORTB 2.5 video params that are closely aligned to video properties we currently support. As discussed in the linked ticket, due to a number of unique values that are available/used by our ad-server but that are not supported by the ORTB spec - the
bids.params.videoare still read and would be preferred (if present) over the mediaType values.