Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undertone, Unruly, Concert, Adform: stub support for advertiserDomains #6727

Merged
merged 33 commits into from
May 8, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
c2f2046
Update eids.js
patmmccann Mar 25, 2021
c422dc9
Update eids_spec.js
patmmccann Mar 25, 2021
ec752ee
Update eids.js
patmmccann Mar 25, 2021
ea44e21
Update pubmaticBidAdapter_spec.js
patmmccann Mar 25, 2021
d44f298
Update eids.js
patmmccann Mar 25, 2021
10efcdd
Update eids_spec.js
patmmccann Mar 25, 2021
78fb35f
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
5c082a1
Update rubiconBidAdapter_spec.js
patmmccann Mar 25, 2021
09741b0
Update conversantBidAdapter_spec.js
patmmccann Mar 25, 2021
f42f6d8
Delete test/spec/adapters directory
patmmccann Mar 25, 2021
35de176
Update userId_spec.js
patmmccann Mar 25, 2021
078473b
Merge pull request #2 from prebid/master
patmmccann Mar 30, 2021
e7b5d01
Merge pull request #3 from prebid/master
patmmccann Apr 6, 2021
3501414
Delete iasBidAdapter.js
patmmccann Apr 14, 2021
7f186df
Merge pull request #5 from prebid/master
patmmccann Apr 19, 2021
a3023ff
Add files via upload
patmmccann Apr 19, 2021
6971384
Update openxBidAdapter.js
patmmccann Apr 27, 2021
7b3b306
Update openxBidAdapter.js
patmmccann Apr 27, 2021
e8f01f7
Merge branch 'prebid:master' into master
patmmccann May 7, 2021
89dffbe
Update concertBidAdapter.js
patmmccann May 7, 2021
4e31322
Update unrulyBidAdapter.js
patmmccann May 7, 2021
05427ff
Update undertoneBidAdapter.js
patmmccann May 7, 2021
8de139f
Update adformBidAdapter.js
patmmccann May 7, 2021
4918ce8
Update adformBidAdapter_spec.js
patmmccann May 7, 2021
53dd67e
Update unrulyBidAdapter_spec.js
patmmccann May 7, 2021
0476d5a
Update concertBidAdapter_spec.js
patmmccann May 7, 2021
80414d5
Update undertoneBidAdapter_spec.js
patmmccann May 7, 2021
9bd6194
Update undertoneBidAdapter.js
patmmccann May 7, 2021
d33aef9
Update adformBidAdapter_spec.js
patmmccann May 7, 2021
a580285
Update adformBidAdapter_spec.js
patmmccann May 7, 2021
15d3675
Update undertoneBidAdapter_spec.js
patmmccann May 7, 2021
4ca89be
Update adformBidAdapter_spec.js
patmmccann May 7, 2021
2233957
Update adformBidAdapter_spec.js
patmmccann May 8, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/adformBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ export const spec = {
currency: response.win_cur,
netRevenue: bidRequest.netRevenue !== 'gross',
ttl: 360,
meta: { advertiserDomains: response && response.adomain ? response.adomain : [] },
ad: response.banner,
bidderCode: bidRequest.bidder,
transactionId: bid.transactionId,
Expand Down
1 change: 1 addition & 0 deletions modules/concertBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ export const spec = {
height: bid.height,
ad: bid.ad,
ttl: bid.ttl,
meta: { advertiserDomains: bid && bid.adomain ? bid.adomain : [] },
creativeId: bid.creativeId,
netRevenue: bid.netRevenue,
currency: bid.currency
Expand Down
3 changes: 2 additions & 1 deletion modules/undertoneBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,8 @@ export const spec = {
creativeId: bidRes.adId,
currency: bidRes.currency,
netRevenue: bidRes.netRevenue,
ttl: bidRes.ttl || 360
ttl: bidRes.ttl || 360,
meta: { advertiserDomains: bidRes.adomain ? bidRes.adomain : [] }
};
if (bidRes.mediaType && bidRes.mediaType === 'video') {
bid.vastXml = bidRes.ad;
Expand Down
1 change: 1 addition & 0 deletions modules/unrulyBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const serverResponseToBid = (bid, rendererInstance) => ({
netRevenue: true,
creativeId: bid.bidId,
ttl: 360,
meta: { advertiserDomains: bid && bid.adomain ? bid.adomain : [] },
currency: 'USD',
renderer: rendererInstance,
mediaType: VIDEO
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/adformBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,7 @@ describe('Adform adapter', function () {
assert.equal(result.currency, 'EUR');
assert.equal(result.netRevenue, true);
assert.equal(result.ttl, 360);
assert.deepEqual(result.meta.advertiserDomains, [])
assert.equal(result.ad, '<tag1>');
assert.equal(result.bidderCode, 'adform');
assert.equal(result.transactionId, '5f33781f-9552-4ca1');
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/concertBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ describe('ConcertAdapter', function () {
describe('spec.interpretResponse', function() {
it('should return bids in the shape expected by prebid', function() {
const bids = spec.interpretResponse(bidResponse, bidRequest);
const requiredFields = ['requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'creativeId', 'netRevenue', 'currency'];
const requiredFields = ['requestId', 'cpm', 'width', 'height', 'ad', 'ttl', 'meta', 'creativeId', 'netRevenue', 'currency'];

requiredFields.forEach(function(field) {
expect(bids[0]).to.have.property(field);
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/undertoneBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,7 @@ describe('Undertone Adapter', () => {
expect(bid.cpm).to.equal(100);
expect(bid.width).to.equal(300);
expect(bid.height).to.equal(250);
expect(bid.meta.advertiserDomains).to.deep.equal([]);
expect(bid.creativeId).to.equal(15);
expect(bid.currency).to.equal('USD');
expect(bid.netRevenue).to.equal(true);
Expand Down
1 change: 1 addition & 0 deletions test/spec/modules/unrulyBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,6 +148,7 @@ describe('UnrulyAdapter', function () {
netRevenue: true,
creativeId: 'mockBidId',
ttl: 360,
meta: { advertiserDomains: [] },
currency: 'USD',
renderer: fakeRenderer,
mediaType: 'video'
Expand Down