Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized AdUp Technology bid adapter: add support for native, adomain, and multibid #6800

Merged
merged 1 commit into from
May 27, 2021

Conversation

SteffenAnders
Copy link
Contributor

@SteffenAnders SteffenAnders commented May 20, 2021

Type of change

  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Other

Description of change

Example banner implementation

var adUnits = [
   {
        code: "example1",
        mediaTypes: {
            banner: {
                sizes: [[300, 250], [300, 600]],
            }
        },
        bids: [{
            bidder: "aduptech",
            params: {
                publisher: "prebid",
                placement: "12345"
            }
        }]
   }
];

Example native implementation

var adUnits = [
   {
        code: "example2",
        mediaTypes: {
            native: {
                image: {
                    required: true,
                    sizes: [150, 150]
                },
                title: {
                    required: true
                },
                body: {
                    required: true
                },
                clickUrl: {
                    required: true
                },
                displayUrl: {
                    required: true
                },
                sponsoredBy: {
                    required: true
                }
            }
        },
        bids: [{
            bidder: "aduptech",
            params: {
                publisher: "prebid",
                placement: "12345"
            }
        }]
   }
];

@SteffenAnders SteffenAnders force-pushed the optimize_aduptech_adapter branch from 94d6863 to f365bbd Compare May 20, 2021 10:20
@SteffenAnders
Copy link
Contributor Author

It seems that randomly some tests for "Prebid Manager Analytics Adapter" in IE 11 are failing.
This should not have anything to do with my code changes. :(

@patmmccann patmmccann changed the title Optimized AdUp Technology bid adapter Optimized AdUp Technology bid adapter: add support for native, adomain, and multibid May 20, 2021
@Rothalack Rothalack self-requested a review May 27, 2021 18:21
@Rothalack
Copy link
Collaborator

This looks good, worked first try in testing nice and easy.

I think Chris is working on a fix for the build testing. I'm going to keep an eye on that and make sure we're stable again before I merge this.

@Rothalack Rothalack merged commit f2befaa into prebid:master May 27, 2021
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants