Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sspBC Bid Adapter: add bidfloor to imp and other updates to bid adapter #6820

Merged
merged 6 commits into from
May 27, 2021
Merged

sspBC Bid Adapter: add bidfloor to imp and other updates to bid adapter #6820

merged 6 commits into from
May 27, 2021

Conversation

wojciech-bialy-wpm
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Update sspBCBidAdapter to a new version, with following changes:

  • ad bidFloor data to imp (if provided in bidRequest)
  • remove old params.bidFloor logic
  • remove bidFloor check in interpretResponse (as it is handled by prebid.js bidFloors module)
  • disable user sync on inventory that still uses TCF1
  • code cleanup

wojciech-bialy-wpm and others added 6 commits August 18, 2020 11:16
@wojciech-bialy-wpm
Merge pull request #1 from prebid/master
1a37b62 
Update master branch of grupawp/Prebid.js
@wojciech-bialy-wpm
Update tests for sspBC adapter
5a90ba4 
Update tests for sspBC adapter:
- change userSync test (due to tcf param appended in v4.6)
- add tests for onBidWon and onTimeout
@wojciech-bialy-wpm
Merge pull request #9 from prebid/master
2183a85 
Update master branch of grupawp/Prebid.js
[sspbc-adapter] Update to v4.8 (floorprices, usersync, code cleaning)
30e140d
[sspbc-adapter] remove bidloor param from md. Remove unused test for …
c3cc5a2 
…old module (sspBCAdapter)
@wojciech-bialy-wpm
Merge pull request #10 from prebid/master
d62d4cf 
Update sspbc 4.9 branch
@ChrisHuie ChrisHuie changed the title Update sspBCBidAdapter to v4.9 sspBC Bid Adapter: add bidfloor to imp and other updates to bid adapter May 24, 2021
@Rothalack
Copy link
Collaborator

This looks to be working for me. There's one documentation update I think you need, wouldn't you want to show Floors Module Support as yes on your dev-docs page? Any other edits you think you need?
https://docs.prebid.org/dev-docs/bidders/sspBC

@wojciech-bialy-wpm
Copy link
Contributor Author

Hmm... No, I think support for getFloor is the only one.

Added in this pull request: prebid/prebid.github.io#2992

@Rothalack
Copy link
Collaborator

Looks good!

@Rothalack Rothalack merged commit 54bdd70 into prebid:master May 27, 2021
@ChrisHuie ChrisHuie requested a review from Rothalack May 27, 2021 15:18
@Rothalack
Copy link
Collaborator

@ChrisHuie Is there an issue with this?

@wojciech-bialy-wpm wojciech-bialy-wpm deleted the sspbc-4.9 branch January 3, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rothalack Rothalack Awaiting requested review from Rothalack

Assignees

@Rothalack Rothalack

Labels
maintenance minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wojciech-bialy-wpm @Rothalack @ChrisHuie