Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nextmillinnium adapter improvement #6957

Merged
merged 4 commits into from
Jun 7, 2021
Merged

Nextmillinnium adapter improvement #6957

merged 4 commits into from
Jun 7, 2021

Conversation

mifanich
Copy link
Contributor

@mifanich mifanich commented Jun 7, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • [x ] Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Update ENDPOINT, email

  • test parameters for validating bids
{
  bidder: 'nextMillennium',
  params: {
    placement_id: '528'
  }
}
  • contact email of the adapter’s maintainer
  • official adapter submission

Doc's PR: prebid/prebid.github.io#3010

@harpere harpere requested a review from msm0504 June 7, 2021 15:29
@msm0504 msm0504 added the LGTM label Jun 7, 2021
@msm0504 msm0504 merged commit 8cac6d7 into prebid:master Jun 7, 2021
@mifanich mifanich deleted the nextmillinnium-adapter-improvement branch July 20, 2021 12:50
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
@agrandes-tappx
Nextmillinnium adapter improvement (prebid#6957)
41c85d9 
* change structure of request and response

* fixes

* remove logInfo

* update doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msm0504 msm0504 msm0504 approved these changes

Assignees

@msm0504 msm0504

Labels
feature LGTM needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mifanich @msm0504 @harpere