Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Orbidder Bid Adapter: add native support #7047

Merged
merged 3 commits into from
Jul 6, 2021
Merged

Orbidder Bid Adapter: add native support #7047

merged 3 commits into from
Jul 6, 2021

Conversation

arneschulz1984
Copy link
Contributor

Type of change

  • Feature

Description of change

Adding native support to orbidder adapter

Contact email

@ChrisHuie ChrisHuie changed the title Feature/orbidder add native support Orbidder Bid Adapter: add native support Jun 18, 2021
@ChrisHuie ChrisHuie requested a review from aleksatr June 18, 2021 17:46
@aleksatr aleksatr added the minor label Jun 22, 2021
@arneschulz1984
Copy link
Contributor Author

Hi, one short question, do we have to do something here?
The Circle CI job failed, but we only changed some documentation.
Should i trigger ab build again by pushing a new commit?
Greetings

@aleksatr
Copy link
Contributor

Hi, one short question, do we have to do something here?
The Circle CI job failed, but we only changed some documentation.
Should i trigger ab build again by pushing a new commit?
Greetings

Since the error was not linked to your adapter, I just reran the CircleCI job and now you have your build/tests passing.

@arneschulz1984
Copy link
Contributor Author

arneschulz1984 commented Jul 5, 2021 •
edited
Loading

Hi @aleksatr,
can you give me a notice, with witch release our feature will be released.
Our partners are waiting for our native supporting adapter.

Greetings

@aleksatr aleksatr added the LGTM label Jul 6, 2021
@aleksatr aleksatr merged commit 089e43a into prebid:master Jul 6, 2021
@aleksatr
Copy link
Contributor

aleksatr commented Jul 6, 2021

hi @arneschulz1984 , sorry for the delay, it will be released in 5.4.0.

@arneschulz1984
Copy link
Contributor Author

hi @arneschulz1984 , sorry for the delay, it will be released in 5.4.0.

Hi @aleksatr, thanks a lot!
Have a nice day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksatr aleksatr Awaiting requested review from aleksatr

Assignees

@aleksatr aleksatr

Labels
feature LGTM minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arneschulz1984 @aleksatr @ChrisHuie