Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINR Bid Adapter: add new bid adapter #7050

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Conversation

winrdev
Copy link
Contributor

@winrdev winrdev commented Jun 18, 2021

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
var adUnits = [
  {
    code: "winr-demo",
    mediaTypes: {
      banner: {
        sizes: [[1, 1]],
      },
    },
    bids: [
      {
        bidder: "winr",
        params: {
          placementId: 21764100,
          domParent: ".blog-post",
          child: 4,
        },
      },
    ],
  },
];

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer: tech@winr.com.au
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Jun 18, 2021

@winrdev I don't think I have come across a bid adapter that wraps a bid with custom scripts and html in this way before. Not sure how comfortable I am at returning a template string with executable code. Will probably have to bring this pr up in the next prebid javascript meeting

@winrdev
Copy link
Contributor Author

winrdev commented Jun 21, 2021

@winrdev I don't think I have come across a bid adapter that wraps a bid with custom scripts and html in this way before. Not sure how comfortable I am at returning a template string with executable code. Will probably have to bring this pr up in the next prebid javascript meeting

@ChrisHuie We understand your concerns, however our ad units are unique in that they have a specific set of features outside of what traditional ads provide. These include features such as the ability to behave like a paywall in terms of temporarily redacting part of the article content. We have a one-to-one relationship with our publishers, given the unique nature of our content.

I hope this helps to resolve some of your concerns. We also noticed a few other adapters using a similar approach with bid wrapping i.e. Vox, AstraOne, TE Medya, FreeWheel and hybrid.ai

@ChrisHuie
Copy link
Collaborator

@winrdev confirmed this is ok. Merging this pr later today. Thanks for your patience on it :)

@ChrisHuie ChrisHuie merged commit c0454c8 into prebid:master Jun 23, 2021
@winrdev
Copy link
Contributor Author

winrdev commented Jun 24, 2021

Many thanks @ChrisHuie :)

prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
* WINR Bid Adapter: add new bid adapter

* Updated winrBidAdapter.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants