-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RtbSape Bid Adapter: restore for Prebid 5.x #7081
Conversation
@ne0n it doesn't appear that the requirements for prebid 5.0 have been added? Adomain, schain, support for floors module, and etc. |
The adapter works correctly with base Prebid 5.0. But... I'm not sure that we support all modules from Prebid 5.0. The adapter sends the original BidRequest object to the endpoint, but the endpoint might ignore some options. We plan to improve our endpoint as we receive requests from publishers. Is it critical? |
I missed topic #6650, this is my mistake. We always set meta.advertiserDomains for every bid. It is implemented on a server side. |
@ChrisHuie, good day. Everything is fine? Or maybe I need to fix something else? |
@ChrisHuie, adomain is contained in the response from the server. Always for all bids: |
@ne0n that's fine this way then. Do your unit tests check the server response? Could you add a unit test to check adomain? |
@ChrisHuie. I added adomain check to the adapter and updated the unit tests for this case. |
* RtbSape Bid Adapter: restore for Prebid 5.x * RtbSape Bid Adapter: check adomain (prebid#7081) Co-authored-by: Dmitry Latyshev <d.latyshev@gmail.com>
Type of change
Description of change
Restore RtbSape Bid Adapter after remove for Prebid 5.0. Campaign with ads for test now available.