-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iqm Bid Adapter: add new bid adapter #7111
Conversation
Hello @ChrisHuie can you help us out with why this adapter tests are failing at browser stack testing as it works fine on local setup. |
@Params10 we have a flaky ie test that was bad for a few days. If you pull in recent merges there is a fix in there that helps with it. |
I've noticed a few things from trying to test. There appears to be a change to package-lock.json, that may be my fault from testing, but please double check that you did not change the package settings on your end. In testing, I'm getting a 400 Bad Request response from POST https://pdb.bids.iqm.com. I think I have the bidder set up properly so I would not expect that response. Let me know if you have any testing placement/publisher id to test with. I see in your documentation PR prebid/prebid.github.io#3069 you have the geo/country setting in your example, but it's not listed in your params documentation. I would either update your documentation to show that geo/country is a param, or remove it from the example bidder to avoid any confusion. |
And pulling in master should help with the Circleci test. |
Hello, any updates for the pull request ? |
Hey @Params10 . The merge with master fixed the package json issue and testing issues, so that's good to go. That just leaves my question about your documentation regarding geo. I see in your test params here, geo is included, in your testing examples in your documentation it shows geo, then in your list of params in documentation, geo is not listed. I think you should either update your list of available params in documentation to include geo, or remove geo from your test examples. Without clearing that up, it will likely confuse users. |
I see your update to your docs, this is good to go! |
Type of change
Description of change
Added new IQM bid adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information