-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opera Ads Bid Adapter: add new bid adapter #7152
Conversation
Hi @xingwangl ,
and then view the coverage by launching
|
This comment has been minimized.
This comment has been minimized.
Oh, I found you are using wrong parameters. Try these:
|
Hi @musikele , I updated the test units, now it has a code coverage above 90%. |
Hi @musikele, Please continue reviewing when you are available, thanks. |
Hey @yuansi-piao , the test codes you gave me in the previous comment will work also for video and native? |
Hi @musikele, the placement id is also for native and video ad. There are some test code I used to test the ads: Instream video:
native:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
For future reviews, add the working test params in the .md file so it's easier to find them.
* feat(operaads): add Opera Ads bid adapter * fix(operaads): fix sharedId support * chore(operaads): remove user sync support * feat(operaads): no need to set width and height when native ad is requested * fix(operaads): decode native icon url * test(operaads): add more test cases * fix(operaads): fix native response parse * feat(operaads): track bid won * test(operaads): update test cases
Type of change
Description of change
Add Opera Ads bid adapter.
Be sure to test the integration with your adserver using the sample page.
Done, tested with the Hello World page.
Email: adtech-prebid-group@opera.com
Docs: prebid/prebid.github.io#3092