Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gptPreAuction Module: update to include MCM support #7242

Merged
merged 5 commits into from
Aug 2, 2021

Conversation

mmoschovas
Copy link
Contributor

@mmoschovas mmoschovas commented Jul 30, 2021

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

The gptPreAuction module is not be compatible with the approach/format that Google uses for MCM (Multiple Customer Management). This update addresses the underlying issue by trimming the child ID from the ad unit name.

Ad Slot Definition: /123456,7654321/Ad_Unit_Name/1234567890

This is currently being passed via FPD as is under imp[].ext.data.pbadslot/adserver.adslot. SSPs will have issues reading this value due to the comma separated IDs.

Trimmed Name for FPD: /123456/Ad_Unit_Name/1234567890

This update also includes a config enablement via

pbjs.setConfig({
    gptPreAuction:{
        mcmEnabled: trrue
    }
});

@ChrisHuie ChrisHuie changed the title Updating gptPreAuction module to include MCM support gptPreAuction: update to include MCM support Jul 30, 2021
@ChrisHuie ChrisHuie changed the title gptPreAuction: update to include MCM support gptPreAuction Module: update to include MCM support Jul 30, 2021
@ChrisHuie ChrisHuie self-requested a review August 2, 2021 14:04
@ChrisHuie ChrisHuie self-assigned this Aug 2, 2021
@ChrisHuie ChrisHuie self-requested a review August 2, 2021 14:05
@ChrisHuie
Copy link
Collaborator

@mmoschovas does a unit test need to be added for when MCM is enabled or is that already covered by the current testing?

@mmoschovas
Copy link
Contributor Author

@ChrisHuie yes let me add a test in now. Hold off on merging until this is updated

@mmoschovas
Copy link
Contributor Author

@ChrisHuie test have been added

@ChrisHuie ChrisHuie merged commit 3162aa9 into master Aug 2, 2021
@ChrisHuie ChrisHuie deleted the gptPreAuction-update-mcm branch August 2, 2021 18:14
@patmmccann
Copy link
Collaborator

very happy this merged but just a reminder 2nd reviewer required on non-vendor specific modules as well

@bretg
Copy link
Collaborator

bretg commented Aug 13, 2021

FWIW - this was missing the doc update. Fixed in prebid/prebid.github.io#3206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants