-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gptPreAuction Module: update to include MCM support #7242
Conversation
@mmoschovas does a unit test need to be added for when MCM is enabled or is that already covered by the current testing? |
@ChrisHuie yes let me add a test in now. Hold off on merging until this is updated |
@ChrisHuie test have been added |
very happy this merged but just a reminder 2nd reviewer required on non-vendor specific modules as well |
FWIW - this was missing the doc update. Fixed in prebid/prebid.github.io#3206 |
Type of change
Description of change
The gptPreAuction module is not be compatible with the approach/format that Google uses for MCM (Multiple Customer Management). This update addresses the underlying issue by trimming the child ID from the ad unit name.
Ad Slot Definition:
/123456,7654321/Ad_Unit_Name/1234567890
This is currently being passed via FPD as is under imp[].ext.data.pbadslot/adserver.adslot. SSPs will have issues reading this value due to the comma separated IDs.
Trimmed Name for FPD:
/123456/Ad_Unit_Name/1234567890
This update also includes a config enablement via