Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adkernel Bid Adapter : added catapultx alias #7435

Merged
merged 3 commits into from
Oct 28, 2021
Merged

adkernel Bid Adapter : added catapultx alias #7435

merged 3 commits into from
Oct 28, 2021

Conversation

jtammaro
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • [ X ] Other

Description of change

Added new alias to adkernel's bid adapter

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

added catapultx alias
@ChrisHuie ChrisHuie changed the title Update adkernelBidAdapter.js : added catapultx alias adkernel Bid Adapter : added catapultx alias Sep 17, 2021
@ChrisHuie ChrisHuie self-requested a review September 17, 2021 15:29
@ChrisHuie ChrisHuie self-assigned this Sep 17, 2021
@ChrisHuie
Copy link
Collaborator

@jtammaro looks like you have a small linting error on this pr. FYI

@ChrisHuie
Copy link
Collaborator

@jtammaro following up on this pr. Looks like a small linting error is still holding this one up.

@bretg
Copy link
Collaborator

bretg commented Sep 29, 2021

docs PR prebid/prebid.github.io#3261

@ChrisHuie
Copy link
Collaborator

@jtammaro is this pr still valid? Looks like there are conflicts with your current adapter and this pr.

Copy link
Contributor Author

@jtammaro jtammaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHuie - Hi Chis - thanks for the note, sorry for the delay. Could you point be in the right direction? I ran gulp lint and this was my result

gulp lint
[10:08:42] Using gulpfile ~/Github/Prebid.js/gulpfile.js
[10:08:42] Starting 'lint'...
[10:10:17] Finished 'lint' after 1.58 min

I'm not sure what the lint error is I should be fixing

@ChrisHuie
Copy link
Collaborator

@jtammaro Looks like there is a trailing space behind line 74. Line above the new alias

Copy link
Contributor Author

@jtammaro jtammaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHuie - Thanks, should be all set now - let me know if anything else looks off.

@ChrisHuie
Copy link
Collaborator

ChrisHuie commented Oct 27, 2021

@jtammaro Just tried to fix this myself but looks like I don't have access. There is a conflict with an alias that was added like 3 weeks ago if you can resolve please. 🙏

Copy link
Contributor Author

@jtammaro jtammaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHuie - pulled latest upstream changes and resolved conflict.

@ChrisHuie ChrisHuie merged commit d8b8198 into prebid:master Oct 28, 2021
cpabst pushed a commit to sovrn/Prebid.js that referenced this pull request Jan 10, 2022
* Update adkernelBidAdapter.js

added catapultx alias

* Update adkernelBidAdapter.js

Co-authored-by: James <jt@catapultx.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants