-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adkernel Bid Adapter : added catapultx alias #7435
Conversation
added catapultx alias
@jtammaro looks like you have a small linting error on this pr. FYI |
@jtammaro following up on this pr. Looks like a small linting error is still holding this one up. |
docs PR prebid/prebid.github.io#3261 |
@jtammaro is this pr still valid? Looks like there are conflicts with your current adapter and this pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisHuie - Hi Chis - thanks for the note, sorry for the delay. Could you point be in the right direction? I ran gulp lint
and this was my result
gulp lint
[10:08:42] Using gulpfile ~/Github/Prebid.js/gulpfile.js
[10:08:42] Starting 'lint'...
[10:10:17] Finished 'lint' after 1.58 min
I'm not sure what the lint error is I should be fixing
@jtammaro Looks like there is a trailing space behind line 74. Line above the new alias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisHuie - Thanks, should be all set now - let me know if anything else looks off.
@jtammaro Just tried to fix this myself but looks like I don't have access. There is a conflict with an alias that was added like 3 weeks ago if you can resolve please. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisHuie - pulled latest upstream changes and resolved conflict.
* Update adkernelBidAdapter.js added catapultx alias * Update adkernelBidAdapter.js Co-authored-by: James <jt@catapultx.com>
Type of change
Description of change
Added new alias to adkernel's bid adapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information