build adapter from custom source path #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewlane
approved these changes
Oct 29, 2016
| const adapterNames = adapters.map(getNames).filter(getUniques); | ||
| const adapterNames = adapters.filter(getStandardAdapters).filter(getUniques); | ||
| //adapters loaded from `srcPath` | ||
| const customAdapters = adapters.map(getCustomAdapters).filter( adapter =>{ |
There was a problem hiding this comment.
#nitpick: remove space before adapter and place space between > and {
|
|
||
| if (!inserts.length) { | ||
| console.log('Prebid Warning: no matching adapters found for config, no adapters will be' + | ||
| ' loaded.'); |
There was a problem hiding this comment.
This could be joined with the previous line to get rid of the need for concatenation
| @@ -67,8 +75,11 @@ function insertAdapters() { | |||
| * @returns {string} | |||
| */ | |||
| function adapterName(adapter) { | |||
| const result = adapter.split(''); | |||
| return result[0].toUpperCase() + result.join('').substr(1) + 'Adapter'; | |||
| if(adapter){ | |||
There was a problem hiding this comment.
#nit: space after if and between ) and {
| } | ||
|
|
||
| function getStandardAdapters(adapter) { | ||
| if(typeof adapter === 'string'){ |
There was a problem hiding this comment.
#nit: space after if and between ) and {
|
|
||
| function getCustomAdapters(adapter) { | ||
| const srcPath = getSrcPath(adapter); | ||
| if(srcPath === '') { |
There was a problem hiding this comment.
#space-jam: space after if
| if(srcPath === '') { | ||
| return; | ||
| } | ||
| if(!fileExists(srcPath)){ |
There was a problem hiding this comment.
#nit: space after if and between ) and {
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…ebid-0.14.0 to release/1.7.0 * commit '3eefcf043466f5457c81bfec18b032b53490b78b': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
mp-12301
pushed a commit
to aol/Prebid.js
that referenced
this pull request
Apr 10, 2017
…7.0 to master * commit '262f371a5c855419c3ef357fb1f0cf87a107749f': (52 commits) New adapters ids. Prebid 0.14.0 Release add workaround to prevent IX adapter from ending auction earlier due to one request becoming many responses (prebid#763) Add pbjs.getHighestCpmBids for getting winning bids (prebid#755) Fix build Drop Sekindo adapter. Bugfix/suppress prebid request if sizeMapping undefined for device width (prebid#758) amp integration (prebid#756) Add contribution guidelines (prebid#761) Add api method to shuffle the order bidders are called in (prebid#760) build adapter from custom source path (prebid#753) reduce duplication and ignore ga.js in coverage (prebid#754) Log /ut response errors in dev console (prebid#747) Fix indentation (code style error when building) (prebid#751) Add package keywords (prebid#746) added new rubiconLite adapter (prebid#740) Show warning if bidCpmAdjustment is set for AOL bidder (closes prebid#725) (prebid#728) IX adapter code refactoring (prebid#711) Update memeglobal.js (prebid#737) Pulsepoint Analytics adapter for Prebid (prebid#706) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
You can specify an absolute path for incorporating a custom adapter in
adapters.jsonExample:
Other information
@prebid/core to review