Prebid Core: native puc multiple events fix #7543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHuie
changed the title
ChrisHuie
approved these changes
Oct 19, 2021
Fawke
approved these changes
Oct 20, 2021
cpabst
pushed a commit
to sovrn/Prebid.js
that referenced
this pull request
Jan 10, 2022
* fire bidWon and impression tracker only once * add special test case for 'fireNativeTrackers'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Fire
bidWonand impression tracker only once.Current implementation will fire
bidWonand impression tracker multiple times when native is being render with PUC.PBJS will do that because it's firing events each time PUC sends post message. And PUC is sending 3 post messages when native ad is being rendered:
PUC code: https://github.com/prebid/prebid-universal-creative/blob/master/src/nativeRenderManager.js#L67-L69
Proposed fix will fire
onBidWonand impression tracker only when PUC sends 'fireNativeTracker' post message.This PR resolves #7526 issue.