Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adomik Analytics Adapter: change bid.placementCode to bid.adUnitCode #7610

Merged
merged 2 commits into from
Oct 28, 2021
Merged

Adomik Analytics Adapter: change bid.placementCode to bid.adUnitCode #7610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
90670f1
AdomikAnalyticsAdapter: change placementCode to adUnitCode
liabas-b Oct 18, 2021
fc48dbd
AdomikAnalyticsAdapter: split GET URLs only for MSIE browser
liabas-b Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions modules/adomikAnalyticsAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ const bidRequested = CONSTANTS.EVENTS.BID_REQUESTED;
const bidResponse = CONSTANTS.EVENTS.BID_RESPONSE;
const bidWon = CONSTANTS.EVENTS.BID_WON;
const bidTimeout = CONSTANTS.EVENTS.BID_TIMEOUT;
const ua = navigator.userAgent;

let adomikAdapter = Object.assign(adapter({}),
{
Expand Down Expand Up @@ -47,7 +48,7 @@ let adomikAdapter = Object.assign(adapter({}),
type: 'request',
event: {
bidder: bid.bidder.toUpperCase(),
placementCode: bid.placementCode
placementCode: bid.adUnitCode
}
});
});
Expand All @@ -67,6 +68,10 @@ adomikAdapter.initializeBucketEvents = function() {
adomikAdapter.bucketEvents = [];
}

adomikAdapter.maxPartLength = function () {
return (ua.includes(' MSIE ')) ? 1600 : 60000;
};

adomikAdapter.sendTypedEvent = function() {
const groupedTypedEvents = adomikAdapter.buildTypedEvents();

Expand Down Expand Up @@ -108,9 +113,10 @@ adomikAdapter.sendTypedEvent = function() {
// Encode object in base64
const encodedBuf = window.btoa(stringBulkEvents);

// Create final url and split it in 1600 characters max (+endpoint length)
// Create final url and split it (+endpoint length)
const encodedUri = encodeURIComponent(encodedBuf);
const splittedUrl = encodedUri.match(/.{1,1600}/g);
const maxLength = adomikAdapter.maxPartLength();
const splittedUrl = encodedUri.match(new RegExp(`.{1,${maxLength}}`, 'g'));

splittedUrl.forEach((split, i) => {
const partUrl = `${split}&id=${adomikAdapter.currentContext.id}&part=${i}&on=${splittedUrl.length - 1}`;
Expand All @@ -121,7 +127,7 @@ adomikAdapter.sendTypedEvent = function() {

adomikAdapter.sendWonEvent = function (wonEvent) {
const stringWonEvent = JSON.stringify(wonEvent)
logInfo('Won event sent to adomik prebid analytic ' + wonEvent);
logInfo('Won event sent to adomik prebid analytic ' + stringWonEvent);

// Encode object in base64
const encodedBuf = window.btoa(stringWonEvent);
Expand Down
4 changes: 3 additions & 1 deletion test/spec/modules/adomikAnalyticsAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import adomikAnalytics from 'modules/adomikAnalyticsAdapter.js';
import {expect} from 'chai';

let events = require('src/events');
let adapterManager = require('src/adapterManager').default;
let constants = require('src/constants.json');
Expand All @@ -8,6 +9,7 @@ describe('Adomik Prebid Analytic', function () {
let sendEventStub;
let sendWonEventStub;
let clock;

before(function () {
clock = sinon.useFakeTimers();
});
Expand Down Expand Up @@ -91,7 +93,7 @@ describe('Adomik Prebid Analytic', function () {
type: 'request',
event: {
bidder: 'BIDDERTEST',
placementCode: 'placementtest',
placementCode: '0000',
}
});

Expand Down