Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tappx Bid Adapter: add vendor id #7709

Merged
merged 2 commits into from
Nov 15, 2021
Merged

Tappx Bid Adapter: add vendor id #7709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4dc4302
Tappx :: Add vendor id
agrandes-tappx Nov 15, 2021
507e337
add unit test
ChrisHuie Nov 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion modules/tappxBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,10 @@ import { config } from '../src/config.js';
import { Renderer } from '../src/Renderer.js';

const BIDDER_CODE = 'tappx';
const GVLID_CODE = 628;
const TTL = 360;
const CUR = 'USD';
const TAPPX_BIDDER_VERSION = '0.1.1004';
const TAPPX_BIDDER_VERSION = '0.1.1005';
const TYPE_CNN = 'prebidjs';
const LOG_PREFIX = '[TAPPX]: ';
const VIDEO_SUPPORT = ['instream', 'outstream'];
Expand Down Expand Up @@ -42,6 +43,7 @@ var hostDomain;

export const spec = {
code: BIDDER_CODE,
gvlid: GVLID_CODE,
supportedMediaTypes: [BANNER, VIDEO],

/**
Expand Down
4 changes: 4 additions & 0 deletions test/spec/modules/tappxBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,10 @@ describe('Tappx bid adapter', function () {
badBidRequest_v.bids.mediaTypes.video.playerSize = [320, 250];
assert.isFalse(spec.isBidRequestValid(badBidRequest_v.bids));
});

it('should export the TCF vendor ID', function () {
expect(spec.gvlid).to.equal(628);
})
});

/**
Expand Down