Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid core & currency module: fix race condition on slow fetch of currency conversion file #7851

Merged
merged 1 commit into from
Jan 13, 2022
Merged

Prebid core & currency module: fix race condition on slow fetch of currency conversion file #7851

merged 1 commit into from
Jan 13, 2022

Commits on Dec 11, 2021

  1. Prebid core & currency module: fix race condition on slow fetch of cu… 

    …rrency conversion file

The currency module hooks into the auction's `addBidResponse` flow to modify bid responses with currency info. To do this it needs to fetch conversion rates from the network, but the auction expects `addBidResponse` to complete synchronously, and things break down if all bidder network calls complete before the currency file fetch.

This fix allows the `addBidResponse` hook to return a promise. If it does, the auction will wait for it before ending.

Addresses prebid#7765
    @dgirardi
    dgirardi committed Dec 11, 2021
    Configuration menu
    Copy the full SHA
    dd8316a View commit details
    Browse the repository at this point in the history