Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flashtalking FTRACK User ID Submodule: initial release #8063
Flashtalking FTRACK User ID Submodule: initial release #8063
Changes from 8 commits
f6a8fbe
19ccd2b
5da7097
4ba6208
8daacfe
3dfecd8
f86307b
9ef5608
21e5a9a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the code appears to be an attempt to form a fingerprint. The RTD module you provide sends user segments. Is anything in the paragraph below accurate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann
Flashtalking's FTrack ID should not be considered fingerprinting software since Fingerprinting, as defined by Google, includes opaque or hidden techniques, tracking in a covert manner, and identity creation without user knowledge or their ability to opt out.
We feel it is extremely important to inform potential partners of the difference between fingerprinting as an opaque, hidden, covert tracking system without user knowledge and transparency and FTrack as a consent-driven, privacy-friendly probabilistic ID. We welcome the opportunity to walk through exactly what FTrack can, does, and doesn't do in terms of user data and our extensive system-wide privacy tools designed to maximize transparency around our tools to users on the open web.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this in committee and we're not comfortable with the collect signals functionality of your code. You still have a couple of options that could lead to a merge. Many of your peer identity providers simply assume in their submodules that code that is not linked nor contained within this project has run. Eg #7985 provides a reference implementation of both assuming that the publisher has integrated directly with the identity provider, and an implementation that facilitates an integration without referencing the script directly, by making its location a configuration parameter. Many other identity provider reference implementations choose one of these two avenues. If you discover other code in this project collecting signals in the manner of this PR, feel free to flag.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @patmmccann . I shared your feedback with our "committee" and we will make adjustments based on your feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patmmccann The config and code have been changed. Hopefully the change successfully addresses the points the committee made about the previous commit. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the source should just be a domain.
flashtalking.com
is all you need hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edited