Add new adapter districtmDMX #811

stevealliance · 2016-11-17T23:47:32Z

Type of change

[ x] New bidder adapter

Description of change

added districtmDMX to adapters.json
added districtmDMX.js to folder src/adapters
added districtm_specs.js to test for unit testing

test parameters for validating bids

{
  bidder: 'districtmDMX',
  params: {
        id:109800, // required
        floor: 1.10,  // not required
        revShare: 0.90  // not required
        currency: 'cad' // not required will default to 'usd'
  }
}

contact email of the adapter’s maintainer
[steve@districtm.ca ] official adapter submission

Other information

test @97%, two files added one updated

@97

test @97%, two files added one updated

matthewlane

Thanks for the PR. Two requested changes noted below

matthewlane · 2016-11-30T21:20:37Z

test/spec/adapters/districtm_spec.js

+        it('it\'s now time to play with the response ...', ()=>{
+            let result = districtm.handlerRes(PREBID_RESPONSE(), PREBID_PARAMS);
+            _each(result, function(k, v){
+                console.log(11, `${k} value is ${v}`);


In the test directory we try to avoid logging to the console to avoid having non-build related activity displayed during the build process. Please convert this to an assertion if it makes sense or remove the line

matthewlane · 2016-11-30T21:34:21Z

src/adapters/districtmDMX.js

+
+var DistrictmAdaptor = function districtmAdaptor(){
+   let districtmUrl = window.location.protocol + '//prebid.districtm.ca/lib.js';
+   this.callBids = params =>{


The spacing on this line 6 and this line is causing a jscs error: Expected indentation of 2 characters. Please use two spaces on these lines rather than 3, or alternatively, place // jscs:disable at the top of this file to avoid these errors from displaying during the build process

stevealliance · 2016-11-30T22:46:27Z

I just make some change please review

matthewlane · 2016-12-01T17:41:07Z

Thanks for the update. It looks like this adapter is making a call to the same /jpt endpoint as the AppNexus adapter, any reason to not alias the AppNexus adapter instead?

stevealliance · 2016-12-02T16:59:42Z

Yes, we are adding addtional features such as the currency parameter which allows us to send the bid in foreign currency in the ad server. We take care of updating currencies on a daily basis on behalf of the publisher

mkendall07 · 2016-12-02T22:57:43Z

@stevealliance
So you are taking the bid returned by the Bidder and applying a currency conversion to it? How does it compete in the auction with other bidders of different currencies? Just curious how this works. Thanks

stevealliance · 2016-12-03T00:37:14Z

If the publisher has an ad server setup in Canadian as an example, we apply convertion to it.
This is in the case that other end points would also be able to convert, and/or are applying a bid multiplier to reflect the same currency.

Many publishers are having Canadian ad servers, we tought this feature would be an option to simplify the process for them.

They have to be aware that this have to be used in a context of comparing apples to apples.

A little bit like gross vs net.

Thanks

…ebid-official-0.16.0 to release/1.10.0 * commit 'fd16420d7034b1f82e571e2b122b7fa73b88d929': Add changelog entry. Add new adapters for AOL analytics. Updated Prebid version Catch cross-origin DOMException (prebid#861) Add GumGum adapter (prebid#833) Remove duplicate log line in request bids (prebid#859) Utility function getBidIdParamater is misspelled Allow Conversant sizes to be overridden per placement (prebid#816) Add districtmDMX adapter (prebid#811) Truncate bids requested on clearPlacements (prebid#825) (prebid#828) Update adapters.json (prebid#803) Add usersyncing to AppNexus adapters (prebid#845) fixes for bugs in test suite (prebid#810) Pass user object parameters on bid request (prebid#821) fix rubicon deals to be per ad instead of per response (prebid#838) Links bidId in request with adId in response for analytics purposes (prebid#836) Bugfix/issue building from npm (prebid#823) Update build to only run `webpack` to improve build time performance (prebid#809) Cast all Conversant site_ids to a string (prebid#829) Increment pre version

…10.0 to master * commit 'b39f2b12a8ddfa650a8e04e3abd358e60371950a': Add changelog entry. Add new adapters for AOL analytics. Updated Prebid version Catch cross-origin DOMException (prebid#861) Add GumGum adapter (prebid#833) Remove duplicate log line in request bids (prebid#859) Utility function getBidIdParamater is misspelled Allow Conversant sizes to be overridden per placement (prebid#816) Add districtmDMX adapter (prebid#811) Truncate bids requested on clearPlacements (prebid#825) (prebid#828) Update adapters.json (prebid#803) Add usersyncing to AppNexus adapters (prebid#845) fixes for bugs in test suite (prebid#810) Pass user object parameters on bid request (prebid#821) fix rubicon deals to be per ad instead of per response (prebid#838) Links bidId in request with adId in response for analytics purposes (prebid#836) Bugfix/issue building from npm (prebid#823) Update build to only run `webpack` to improve build time performance (prebid#809) Cast all Conversant site_ids to a string (prebid#829) Increment pre version

internetchris · 2018-05-15T16:06:49Z

@stevealliance/ @mkendall07 - I'm upgrading prebid from 0.24. to 1.10 and don't see an adapter listed in the modules folder for districtmDMX. Subsequently, I'm getting this error now in my prebid output: Adapter trying to be called which does not exist: districtmDMX adaptermanager.callBids

Can you advise if this adapter is still supported and the proper module I should be including in my build. FWIW, I did compile prebid with all of the adapters and still received the same message.

ghost · 2018-06-12T06:58:57Z

Can someone answer @internetchris's question? And I have the same issue right now. Thanks!

lizardslair · 2018-06-22T16:57:16Z

@stevealliance Any news on if there will be a DistrictmDMX module compatable with > 1.10? We are currently performing an (overdue) upgrade from PB 0.21 and while DistrictmDMX is still listed in the official list of bidders, there is no districtmDMXBidAdapter.js file under /modules. Are you the point person for this update or is the community of devs supposed to chime in? We have several properties that use DistrictM and don't want to push our upgrade live until we get them working again. @matthewlane

stevealliance · 2018-06-22T19:19:41Z

@lizardslair I have a PR in review for next release #2765
You can also use our AppNexus alias, but please confirm with you account manager before doing the switch.

Thanks

adding DMX

5711b57

test @97%, two files added one updated

matthewlane added the needs review label Nov 29, 2016

matthewlane self-assigned this Nov 29, 2016

matthewlane reviewed Nov 30, 2016

View reviewed changes

matthewlane added needs update and removed needs review labels Nov 30, 2016

stevealliance added 2 commits November 30, 2016 17:43

Update districtm_spec.js

ad33b56

Update districtmDMX.js

fbd31ff

matthewlane removed the needs update label Dec 1, 2016

mkendall07 added this to the Prebid 0.16.0 milestone Dec 5, 2016

matthewlane merged commit 1d32623 into prebid:master Dec 5, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new adapter districtmDMX #811

Add new adapter districtmDMX #811

stevealliance commented Nov 17, 2016 •

edited

Loading

matthewlane left a comment

matthewlane Nov 30, 2016

matthewlane Nov 30, 2016

stevealliance commented Nov 30, 2016

matthewlane commented Dec 1, 2016

stevealliance commented Dec 2, 2016

mkendall07 commented Dec 2, 2016

stevealliance commented Dec 3, 2016

internetchris commented May 15, 2018

ghost commented Jun 12, 2018

lizardslair commented Jun 22, 2018

stevealliance commented Jun 22, 2018

Add new adapter districtmDMX #811

Add new adapter districtmDMX #811

Conversation

stevealliance commented Nov 17, 2016 • edited Loading

Type of change

Description of change

Other information

matthewlane left a comment

Choose a reason for hiding this comment

matthewlane Nov 30, 2016

Choose a reason for hiding this comment

matthewlane Nov 30, 2016

Choose a reason for hiding this comment

stevealliance commented Nov 30, 2016

matthewlane commented Dec 1, 2016

stevealliance commented Dec 2, 2016

mkendall07 commented Dec 2, 2016

stevealliance commented Dec 3, 2016

internetchris commented May 15, 2018

ghost commented Jun 12, 2018

lizardslair commented Jun 22, 2018

stevealliance commented Jun 22, 2018

stevealliance commented Nov 17, 2016 •

edited

Loading