Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid core: make GDPR/USP consent data available without requiring an auction #8185

Merged
merged 4 commits into from
Apr 2, 2022

Conversation

dgirardi
Copy link
Collaborator

Type of change

  • Feature

Description of change

This extends #8071 to make access to GPDR/USP consent data possible even when no auction is started.

Use case: #7803

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgirardi Looks good overall and seems to work. There are a few places in the jsdoc comments where I think the function parameter names have not been updated.

@@ -38,8 +38,8 @@ const cmpCallMap = {
* @param {function(string)} cmpError acts as an error callback while interacting with the config string; pass along an error message (string)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dgirardi Can you please update the jsdocs blurbs so that it reflects the new API for the functions.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes - I don't know how I completely missed that, thanks for pointing it out!

@ChrisHuie
Copy link
Collaborator

@Fawke @msm0504 following up on this. Looks like it has been updated

@ChrisHuie ChrisHuie removed the request for review from msm0504 April 1, 2022 14:24
@ChrisHuie ChrisHuie self-requested a review April 1, 2022 14:24
@ChrisHuie ChrisHuie self-assigned this Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants