Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loglylift Bid Adapter: add support for banners #8270

Merged
merged 2 commits into from
Apr 8, 2022

Conversation

HashimotoLogly
Copy link
Contributor

@HashimotoLogly HashimotoLogly commented Apr 8, 2022

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • support banner format ad
  • test parameters for validating bids
{
  bidder: 'loglylift',
  params: {
    adspotId: 4302078
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer : dev@logly.co.jp
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@HashimotoLogly HashimotoLogly force-pushed the support_banner_on_loglylift branch 3 times, most recently from d47bb2d to 57a9e72 Compare April 8, 2022 02:24
@HashimotoLogly HashimotoLogly force-pushed the support_banner_on_loglylift branch from 57a9e72 to 7e0f62c Compare April 8, 2022 02:57
@HashimotoLogly HashimotoLogly changed the title Support banner on loglylift Loglylift Bid Adapter: support banner Apr 8, 2022
@ChrisHuie ChrisHuie changed the title Loglylift Bid Adapter: support banner Loglylift Bid Adapter: add support for banners Apr 8, 2022
@ChrisHuie ChrisHuie self-requested a review April 8, 2022 13:44
@ChrisHuie ChrisHuie self-assigned this Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants