-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jixie Bid adapter: support more userids #8314
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
642803b
Adapter does not seem capable of supporting advertiserDomains #6650
jxdeveloper1 103b8ae
removed a blank line at the end of file
jxdeveloper1 704e974
in response to comment from reviewer. add the aspect of advertiserdom…
jxdeveloper1 0d26af8
Merge branch 'prebid:master' into master
jxdeveloper1 b23b95b
Merge branch 'prebid:master' into master
jxdeveloper1 7886688
added the code to get the keywords from the meta tags if available.
jxdeveloper1 b2f8f76
Merge branch 'jixie_add_keyword_frompage'
jxdeveloper1 49f1eca
Merge branch 'prebid:master' into master
jxdeveloper1 e3072fd
adding jixie adaptor to send tid and uid2 and publisher ids
jxdeveloper1 f5abaab
Merge remote-tracking branch 'upstream/master'
jxdeveloper1 138a103
Merge remote-tracking branch 'origin/master' into jx-more-userids
jxdeveloper1 e3e705d
changed to send all the ids to our backend. added a little comment
jxdeveloper1 4389ce4
Merge remote-tracking branch 'upstream/master'
jxdeveloper1 ace4cf2
Merge remote-tracking branch 'origin/master' into jx-more-userids
jxdeveloper1 c72035e
send the config info of price granularity to our backend
jxdeveloper1 6a856cd
corrected code formatting violations that failed some checks
jxdeveloper1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dgirardi please note another location this is occurring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, this does not need to happen - adapters can just take
validBidRequest.userIdsAsEids
.