Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

33Across user id sub-module: initial release #8335

Merged
merged 15 commits into from
May 2, 2022
Merged

33Across user id sub-module: initial release #8335

merged 15 commits into from
May 2, 2022

Conversation

carlosfelix
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add 33across user id sub-module

Docs PR at prebid/prebid.github.io#3736

Other information

cc @jdwieland8282

carlosfelix and others added 15 commits April 28, 2022 12:05
@carlosfelix
wip
9c51f32
@carlosfelix
Rename lexicon param url to apiUrl and remove envelope param
5e20419
@carlosfelix
Rename gvlid spec title - lexicon id system
b483a83
@carlosfelix
add missing semicolon
c5e3e67
@carlosfelix
apply code review feedback lexicon id system
c5ae166
@carlosfelix
Unit test coverage for the callback execution - lexicon id system
7599e08
@carlosfelix
Add lexicon to user id integration example
8721684
@carlosfelix
Add lexicon is system markdown documentation
73a9caf
@carlosfelix @macinjosh32
Update modules/lexiconIdSystem.js
f22d56b 
add colon to error message

Co-authored-by: macinjosh32 <macinjosh32@users.noreply.github.com>
@carlosfelix
Send privacy strings in the lexicon id system request
5abb434
@carlosfelix
apply code review feedback markdown lexicon documentation
2e1592c
@carlosfelix
Rename files with references to lexicon
c7142fb
@carlosfelix
rename 33across ID from lexicon to 33acrossId
f0b7a95
@carlosfelix
fix failing unit tests incorrect URL and error message
70398a6
@carlosfelix
Add 33acrossId reference in submodules & documentation
a527a96
@patmmccann patmmccann changed the title Add 33Across user id sub-module 33Across user id sub-module: initial release Apr 28, 2022
@patmmccann patmmccann requested a review from jlukas79 April 28, 2022 18:58
@jlukas79 jlukas79 merged commit f8c8fca into prebid:master May 2, 2022
@saxsir saxsir mentioned this pull request Oct 5, 2022
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlukas79 jlukas79 jlukas79 approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carlosfelix @jlukas79 @patmmccann