Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talkads Bid Adapter: update params access in case of different ad servers #8390

Merged
merged 4 commits into from
May 9, 2022

Conversation

natexo-technical-team
Copy link
Contributor

@natexo-technical-team natexo-technical-team commented May 9, 2022

Update params access in case of different ad servers.

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

Update params access
@ChrisHuie ChrisHuie self-requested a review May 9, 2022 14:22
@ChrisHuie ChrisHuie self-assigned this May 9, 2022
@ChrisHuie
Copy link
Collaborator

@natexo-technical-team looks like there are a few unit tests failing in this pr

update functions headers
Delete params attribute
Delete params attribute
@natexo-technical-team
Copy link
Contributor Author

Hello,
Everything seems fine now.

@ChrisHuie ChrisHuie changed the title Update talkadsBidAdapter.js talkads Bid Adapter: update params access in case of different ad servers May 9, 2022
@ChrisHuie ChrisHuie merged commit 7f0a56b into prebid:master May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants