Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid 7: Adapter fixes for reading impression position #8451

Merged
merged 18 commits into from
May 26, 2022
Merged

Conversation

patmmccann
Copy link
Collaborator

Attempt at adapter fixes for #5578

@patmmccann patmmccann changed the base branch from master to prebid-7 May 23, 2022 20:10
@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request introduces 3 alerts and fixes 1 when merging d770dc3 into e700568 - view on LGTM.com

new alerts:

  • 2 for Assignment to constant
  • 1 for Useless assignment to local variable

fixed alerts:

  • 1 for Insecure randomness

@lgtm-com
Copy link

lgtm-com bot commented May 23, 2022

This pull request introduces 3 alerts when merging d770dc3 into a8c4a80 - view on LGTM.com

new alerts:

  • 2 for Assignment to constant
  • 1 for Useless assignment to local variable

@patmmccann patmmccann requested a review from ChrisHuie May 25, 2022 19:47
@patmmccann patmmccann linked an issue May 25, 2022 that may be closed by this pull request
@patmmccann patmmccann marked this pull request as ready for review May 25, 2022 19:48
@patmmccann
Copy link
Collaborator Author

part of #7796 release plan

@ChrisHuie ChrisHuie merged commit 187c0d0 into prebid-7 May 26, 2022
@ChrisHuie ChrisHuie deleted the fix-pos branch May 26, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convention for Page Position
2 participants