Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conversant adapter: accept position from the AdUnit #8477

Merged
merged 1 commit into from
May 25, 2022
Merged

Conversant adapter: accept position from the AdUnit #8477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/conversantBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export const spec = {
copyOptProperty(format[0].h, video, 'h');
}

copyOptProperty(bid.params.position, video, 'pos');
copyOptProperty(bid.params.position || videoData.pos, video, 'pos');
copyOptProperty(bid.params.mimes || videoData.mimes, video, 'mimes');
copyOptProperty(bid.params.maxduration || videoData.maxduration, video, 'maxduration');
copyOptProperty(bid.params.protocols || videoData.protocols, video, 'protocols');
Expand All @@ -105,7 +105,7 @@ export const spec = {
const format = convertSizes(bannerData.sizes || bid.sizes);
const banner = {format: format};

copyOptProperty(bid.params.position, banner, 'pos');
copyOptProperty(bid.params.position || bannerData.pos, banner, 'pos');

imp.banner = banner;
}
Expand Down
41 changes: 36 additions & 5 deletions test/spec/modules/conversantBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ describe('Conversant adapter tests', function() {
video: {
context: 'instream',
playerSize: [632, 499],
pos: 3
}
},
placementCode: 'pcode003',
Expand Down Expand Up @@ -108,12 +109,14 @@ describe('Conversant adapter tests', function() {
{
bidder: 'conversant',
params: {
site_id: siteId
site_id: siteId,
position: 2,
},
mediaTypes: {
video: {
context: 'instream',
mimes: ['video/mp4', 'video/x-flv']
mimes: ['video/mp4', 'video/x-flv'],
pos: 7,
}
},
placementCode: 'pcode005',
Expand Down Expand Up @@ -147,6 +150,23 @@ describe('Conversant adapter tests', function() {
bidId: 'bid006',
bidderRequestId: '117d765b87bed38',
auctionId: 'req000'
},
{
bidder: 'conversant',
params: {
site_id: siteId
},
mediaTypes: {
banner: {
sizes: [[728, 90], [468, 60]],
pos: 5
}
},
placementCode: 'pcode001',
transactionId: 'tx001',
bidId: 'bid007',
bidderRequestId: '117d765b87bed38',
auctionId: 'req000'
}
];

Expand Down Expand Up @@ -245,7 +265,7 @@ describe('Conversant adapter tests', function() {
expect(payload).to.have.property('id', 'req000');
expect(payload).to.have.property('at', 1);
expect(payload).to.have.property('imp');
expect(payload.imp).to.be.an('array').with.lengthOf(7);
expect(payload.imp).to.be.an('array').with.lengthOf(8);

expect(payload.imp[0]).to.have.property('id', 'bid000');
expect(payload.imp[0]).to.have.property('secure', 1);
Expand Down Expand Up @@ -287,7 +307,7 @@ describe('Conversant adapter tests', function() {
expect(payload.imp[3]).to.have.property('displaymanagerver').that.matches(versionPattern);
expect(payload.imp[3]).to.not.have.property('tagid');
expect(payload.imp[3]).to.have.property('video');
expect(payload.imp[3].video).to.not.have.property('pos');
expect(payload.imp[3].video).to.have.property('pos', 3);
expect(payload.imp[3].video).to.have.property('w', 632);
expect(payload.imp[3].video).to.have.property('h', 499);
expect(payload.imp[3].video).to.have.property('mimes');
Expand Down Expand Up @@ -325,7 +345,7 @@ describe('Conversant adapter tests', function() {
expect(payload.imp[5]).to.have.property('displaymanagerver').that.matches(versionPattern);
expect(payload.imp[5]).to.not.have.property('tagid');
expect(payload.imp[5]).to.have.property('video');
expect(payload.imp[5].video).to.not.have.property('pos');
expect(payload.imp[5].video).to.have.property('pos', 2);
expect(payload.imp[5].video).to.not.have.property('w');
expect(payload.imp[5].video).to.not.have.property('h');
expect(payload.imp[5].video).to.have.property('mimes');
Expand All @@ -345,6 +365,17 @@ describe('Conversant adapter tests', function() {
expect(payload.imp[6].ext).to.have.property('data');
expect(payload.imp[6].ext.data).to.have.property('pbadslot');

expect(payload.imp[7]).to.have.property('id', 'bid007');
expect(payload.imp[7]).to.have.property('secure', 1);
expect(payload.imp[7]).to.have.property('bidfloor', 0);
expect(payload.imp[7]).to.have.property('displaymanager', 'Prebid.js');
expect(payload.imp[7]).to.have.property('displaymanagerver').that.matches(versionPattern);
expect(payload.imp[7]).to.not.have.property('tagid');
expect(payload.imp[7]).to.have.property('banner');
expect(payload.imp[7].banner).to.have.property('pos', 5);
expect(payload.imp[7].banner).to.have.property('format');
expect(payload.imp[7].banner.format).to.deep.equal([{w: 728, h: 90}, {w: 468, h: 60}]);

expect(payload).to.have.property('site');
expect(payload.site).to.have.property('id', siteId);
expect(payload.site).to.have.property('mobile').that.is.oneOf([0, 1]);
Expand Down