Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kargo Analytics Adapter: Bid response time logging #8510
Kargo Analytics Adapter: Bid response time logging #8510
Changes from all commits
5e6bd1a
797a0f7
88d6cfd
2d79302
0a03e35
2bdf502
b634652
5f6f448
50e0224
a5eda12
f066881
62b1c1e
478191f
d884b69
451080f
c012a35
514f8ce
8639ae7
47646ea
5ebbffb
2dac35a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so having this object at module scope we could possibly see issues if two auctions are running at same time.
The right thing would prob be to just create a local object based off your wanted params here.
Even the
auctionTimeout
part may change between auctions.Now it is probably fine majority of the time. So I can be fine with leaving it if you want.
Let me know.