-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Digital adapter: flag support for native 1.2 JS trackers in bid request #8701
Conversation
did you not want to allow PBS adapter to see this as well if a publisher configures it? Also it seems like we're diverging from PBS adapter here; it would seem a publisher would want to choose this in a consistent way. |
Issue #8665 is about fixing the default in PBS adapter to make JS trackers enabled by default as was the case (and still is in many adapters) with native 1.1. Other bidder adapters which support native ads spec 1.1 all support JS trackers without restriction so in fact PBS adapter diverged by introducing the restriction in its default value and per @bretg's plan in #8665 (comment) the default can be changed in Prebid 8 aligning the native 1.1 and native 1.2 behaviour across adapters. I'm eagerly waiting for the new ortb native support and will certainly make any native params configurable via adunit.native.ortb when adopting ortb. As a side note: it's not our intention to have to ask the publisher for permission as in our interpretation of ortb native 1.2 spec the |
Any chance you could give feeedback directly on #8086 ? |
@patmmccann let me put this PR on hold until next week. |
@jbartek25 8086 is now merged, I think it is fair default this config in your adapter as long as publishers have some way to specify they prefer no js trackers on native |
I'll look into updating the adapter to adopt the ortb native allowing the overrides via the ad unit media type native.ortb object |
After a bunch of discussion, i think we can merge this now, so up to you if you want to make edits or not |
Type of change
Description of change
Improve Digital adapter: Include explicit declaration of native 1.2 JS imp tracker support in bid request. JS trackers were supported already but some DSPs (like DV360) now expect to see explicit confirmation in bid request.