-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prebid core: add utility to retrieve user agent client hints #8826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @dgirardi,
The change looks good to me. I know there's a FPD Enrichment module and validation module.
Do we wanna pre-populate device.sua
and call this library from that module?
In future, if Core needs to access these client hints values instead of parsing the string, do we have to write another function (possibly in utils.js
)?
We would also need to document this.
Thanks.
It makes sense to use this from FPD enrichment, I'll update this PR shortly. I don't understand this:
which string? I think this could be used directly by core, although it wouldn't make sense to have it as a library then. |
I meant the user agent string. For example, here we are checking for a safari browser. I don't know if there'll ever be a use case for Core that makes use of userAgent information. So, I think, it's fine to have it as a library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @dgirardi, The change looks good. But do we wanna put a note in the Prebid.org docs somewhere to let adapter contributors know about this module, and how to use it? |
…8826) * Prebid core: add utility to retrieve user agent client hints * Cache enrichments FPD between auctions * Set device.sua from fpdEnrichment
…8826) * Prebid core: add utility to retrieve user agent client hints * Cache enrichments FPD between auctions * Set device.sua from fpdEnrichment
Type of change
Description of change
This adds a library utility to retrieve UA client hints formatted as an ORTB 2.6
device.sua
object.Note that:
Other information
Closes #8381