Caroda Bid Adapter: initial adapter release #8845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@carodaio looks like you have a few linting errors. If you could please fix 🙏 |
ChrisHuie
changed the title
patmmccann
reviewed
Aug 19, 2022
patmmccann
reviewed
Aug 19, 2022
patmmccann
reviewed
Aug 19, 2022
carodaio
force-pushed
the
prebid-adapter-initial-implementation
branch
from
0b519ab to
e849d66
Compare
JacobKlein26
pushed a commit
to nextmillenniummedia/Prebid.js
that referenced
this pull request
Feb 9, 2023
* WIP| * work on the response format * added md file * some fixes and simplications * made schain optional * tests WIP * fixed bid validation * request common structure tests * added privacy tests * added bid specific logic tests * final unit tests * renamed setOnAny to getFirstWithKey * changed interpretResponse to arrow function * removed extra newline * slight adjustment of request/response format * added ad targeting and ad id to bid response * fixed undefined ad id error * fixed linting * fix: removed setting ad id in interpret response * fix: impoved pageview id handling when caroda is loaded later than prebid * style: added semicolumns * added price type bid validation Co-authored-by: Ioan-Carol Plangu <info@plangu.com>
jorgeluisrocha
pushed a commit
to jwplayer/Prebid.js
that referenced
this pull request
May 23, 2023
* WIP| * work on the response format * added md file * some fixes and simplications * made schain optional * tests WIP * fixed bid validation * request common structure tests * added privacy tests * added bid specific logic tests * final unit tests * renamed setOnAny to getFirstWithKey * changed interpretResponse to arrow function * removed extra newline * slight adjustment of request/response format * added ad targeting and ad id to bid response * fixed undefined ad id error * fixed linting * fix: removed setting ad id in interpret response * fix: impoved pageview id handling when caroda is loaded later than prebid * style: added semicolumns * added price type bid validation Co-authored-by: Ioan-Carol Plangu <info@plangu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Initial implementation of the caroda prebid adapter
[X] Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide: